Bug 236414 - AXIsolatedTree::updateChildren and AXIsolatedTree::nodeAncestryChanges results in adding incorrect nodes to the isolated tree
Summary: AXIsolatedTree::updateChildren and AXIsolatedTree::nodeAncestryChanges result...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-09 16:26 PST by Tyler Wilcock
Modified: 2022-02-10 08:37 PST (History)
10 users (show)

See Also:


Attachments
Patch (9.42 KB, patch)
2022-02-09 16:52 PST, Tyler Wilcock
no flags Details | Formatted Diff | Diff
Patch (9.42 KB, patch)
2022-02-09 16:54 PST, Tyler Wilcock
no flags Details | Formatted Diff | Diff
Patch (10.77 KB, patch)
2022-02-09 17:54 PST, Tyler Wilcock
no flags Details | Formatted Diff | Diff
Patch (10.99 KB, patch)
2022-02-09 17:58 PST, Tyler Wilcock
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (10.99 KB, patch)
2022-02-09 18:30 PST, Tyler Wilcock
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2022-02-09 16:26:30 PST
Sometimes AXIsolatedTree::updateChildren is called with an object that is not in the isolated tree. When this happens, we currently call AXIsolatedTree::nodeAncestryChanges to build the ancestry chain up to the nearest in-isolated-tree node (starting with the original object called for updateChildren).

However, this seems to result in adding nodes to the isolated tree that don't exist in the live tree. I believe this also causes isolated objects to often hold references to parent objects that don't exist in the isolated tree, breaking searches (and more).
Comment 1 Radar WebKit Bug Importer 2022-02-09 16:26:41 PST
<rdar://problem/88721439>
Comment 2 Tyler Wilcock 2022-02-09 16:52:26 PST
Created attachment 451463 [details]
Patch
Comment 3 Tyler Wilcock 2022-02-09 16:54:10 PST
Created attachment 451465 [details]
Patch
Comment 4 Tyler Wilcock 2022-02-09 17:54:43 PST
Created attachment 451474 [details]
Patch
Comment 5 Tyler Wilcock 2022-02-09 17:58:38 PST
Created attachment 451475 [details]
Patch
Comment 6 Tyler Wilcock 2022-02-09 18:30:48 PST
Created attachment 451477 [details]
Patch
Comment 7 EWS 2022-02-10 08:37:54 PST
Committed r289537 (247068@main): <https://commits.webkit.org/247068@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451477 [details].