RESOLVED FIXED 236414
AXIsolatedTree::updateChildren and AXIsolatedTree::nodeAncestryChanges results in adding incorrect nodes to the isolated tree 
https://bugs.webkit.org/show_bug.cgi?id=236414
Summary AXIsolatedTree::updateChildren and AXIsolatedTree::nodeAncestryChanges result...
Tyler Wilcock
Reported 2022-02-09 16:26:30 PST
Sometimes AXIsolatedTree::updateChildren is called with an object that is not in the isolated tree. When this happens, we currently call AXIsolatedTree::nodeAncestryChanges to build the ancestry chain up to the nearest in-isolated-tree node (starting with the original object called for updateChildren). However, this seems to result in adding nodes to the isolated tree that don't exist in the live tree. I believe this also causes isolated objects to often hold references to parent objects that don't exist in the isolated tree, breaking searches (and more).
Attachments
Patch (9.42 KB, patch)
2022-02-09 16:52 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (9.42 KB, patch)
2022-02-09 16:54 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (10.77 KB, patch)
2022-02-09 17:54 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (10.99 KB, patch)
2022-02-09 17:58 PST, Tyler Wilcock 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (10.99 KB, patch)
2022-02-09 18:30 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-02-09 16:26:41 PST
<rdar://problem/88721439>
Tyler Wilcock
Comment 2 2022-02-09 16:52:26 PST
Created attachment 451463 [details] Patch
Tyler Wilcock
Comment 3 2022-02-09 16:54:10 PST
Created attachment 451465 [details] Patch
Tyler Wilcock
Comment 4 2022-02-09 17:54:43 PST
Created attachment 451474 [details] Patch
Tyler Wilcock
Comment 5 2022-02-09 17:58:38 PST
Created attachment 451475 [details] Patch
Tyler Wilcock
Comment 6 2022-02-09 18:30:48 PST
Created attachment 451477 [details] Patch
EWS
Comment 7 2022-02-10 08:37:54 PST
Committed r289537 (247068@main): <https://commits.webkit.org/247068@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451477 [details].
Note You need to log in before you can comment on or make changes to this bug.