Bug 236408 - Use Ref<> for getBackground/MaskShorthandValue
Summary: Use Ref<> for getBackground/MaskShorthandValue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-09 14:14 PST by Matt Woodrow
Modified: 2022-02-10 15:39 PST (History)
8 users (show)

See Also:

Attachments
Patch (4.67 KB, patch)
2022-02-09 14:15 PST, Matt Woodrow 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2022-02-09 14:14:17 PST 
These can never return nullptr, so we should use Ref.
Comment 1 Matt Woodrow 2022-02-09 14:15:55 PST 
Created attachment 451442 [details]
Patch
Comment 2 Tim Nguyen (:ntim) 2022-02-10 12:16:43 PST 
Comment on attachment 451442 [details]
Patch

LGTM! EWS is green too.
Comment 3 EWS 2022-02-10 15:38:13 PST 
Committed r289588 (247101@main): <https://commits.webkit.org/247101@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451442 [details].
Comment 4 Radar WebKit Bug Importer 2022-02-10 15:39:16 PST 
<rdar://problem/88782405>