Bug 236407 - [TextureMapperGL] drop-shadow filter with blur-radius doesn't work as expected if it is the last filter
Summary: [TextureMapperGL] drop-shadow filter with blur-radius doesn't work as expecte...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-09 14:02 PST by Fujii Hironori
Modified: 2022-02-15 15:08 PST (History)
9 users (show)

See Also:


Attachments
test case (1.17 KB, text/html)
2022-02-09 14:02 PST, Fujii Hironori
no flags Details
WIP patch (2.01 KB, patch)
2022-02-09 17:22 PST, Fujii Hironori
no flags Details | Formatted Diff | Diff
WIP patch (1.14 KB, patch)
2022-02-09 18:39 PST, Fujii Hironori
no flags Details | Formatted Diff | Diff
drop-shadow filter and opacity (963 bytes, text/html)
2022-02-09 22:05 PST, Fujii Hironori
no flags Details
WIP patch (2.40 KB, patch)
2022-02-09 22:50 PST, Fujii Hironori
no flags Details | Formatted Diff | Diff
Patch (7.77 KB, patch)
2022-02-13 17:37 PST, Fujii Hironori
no flags Details | Formatted Diff | Diff
Patch (11.08 KB, patch)
2022-02-13 20:25 PST, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2022-02-09 14:02:36 PST
Created attachment 451441 [details]
test case

[TextureMapperGL] drop-shadow filter with blur-radius should expand the intermediate surface to render

css3/filters/effect-drop-shadow-hw.html is a test case.
Comment 1 Fujii Hironori 2022-02-09 17:22:50 PST
Created attachment 451471 [details]
WIP patch
Comment 2 Fujii Hironori 2022-02-09 18:39:33 PST
Created attachment 451479 [details]
WIP patch
Comment 3 Fujii Hironori 2022-02-09 22:05:14 PST
Created attachment 451493 [details]
drop-shadow filter and opacity
Comment 4 Fujii Hironori 2022-02-09 22:50:04 PST
Created attachment 451494 [details]
WIP patch
Comment 5 Fujii Hironori 2022-02-13 17:37:59 PST
Created attachment 451850 [details]
Patch
Comment 6 Fujii Hironori 2022-02-13 20:25:13 PST
Created attachment 451854 [details]
Patch
Comment 7 Don Olmstead 2022-02-15 13:06:10 PST
Comment on attachment 451854 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451854&action=review

r=me using OptionSet is probably more surgery.

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:476
> +    TextureMapperShaderProgram::Options options = 0;

Would we want to turn this into an OptionSet?
Comment 8 Fujii Hironori 2022-02-15 13:13:33 PST
Comment on attachment 451854 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451854&action=review

>> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:476
>> +    TextureMapperShaderProgram::Options options = 0;
> 
> Would we want to turn this into an OptionSet?

Good idea. Will fix in a follow-up.
Comment 9 EWS 2022-02-15 15:07:15 PST
Committed r289855 (247297@main): <https://commits.webkit.org/247297@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451854 [details].
Comment 10 Radar WebKit Bug Importer 2022-02-15 15:08:17 PST
<rdar://problem/88989683>