Parse and add experimental flag for content-visibility.
Created attachment 451391 [details] Patch
Created attachment 451499 [details] Patch
Comment on attachment 451499 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451499&action=review > Source/WebCore/style/StyleBuilderCustom.h:84 > + DECLARE_PROPERTY_CUSTOM_HANDLERS(ContentVisibility); Do we actually need the custom stuff? Initially we had a really custom implementation but now it is pretty standard.
Comment on attachment 451499 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451499&action=review > Source/WebCore/rendering/RenderObject.h:949 > + ADD_BOOLEAN_BITFIELD(layoutContainmentApplies, LayoutContainmentApplies); This bitfield does not seem to be needed for this parsing patch.
Comment on attachment 451499 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451499&action=review >> Source/WebCore/rendering/RenderObject.h:949 >> + ADD_BOOLEAN_BITFIELD(layoutContainmentApplies, LayoutContainmentApplies); > > This bitfield does not seem to be needed for this parsing patch. Done, removed. >> Source/WebCore/style/StyleBuilderCustom.h:84 >> + DECLARE_PROPERTY_CUSTOM_HANDLERS(ContentVisibility); > > Do we actually need the custom stuff? Initially we had a really custom implementation but now it is pretty standard. Hmmm, do you mean all changes in this file is not needed?
Comment on attachment 451499 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451499&action=review > Source/WebCore/style/StyleBuilderCustom.h:1296 > +inline void BuilderCustom::applyInheritContentVisibility(BuilderState& builderState) The value of content-visiblity shouldn't be inherited, so we should remove this.
Comment on attachment 451499 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451499&action=review >>> Source/WebCore/style/StyleBuilderCustom.h:84 >>> + DECLARE_PROPERTY_CUSTOM_HANDLERS(ContentVisibility); >> >> Do we actually need the custom stuff? Initially we had a really custom implementation but now it is pretty standard. > > Hmmm, do you mean all changes in this file is not needed? I am not sure it is possible, but it would be easier if it was generated and not custom code.
Comment on attachment 451499 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451499&action=review >>>> Source/WebCore/style/StyleBuilderCustom.h:84 >>>> + DECLARE_PROPERTY_CUSTOM_HANDLERS(ContentVisibility); >>> >>> Do we actually need the custom stuff? Initially we had a really custom implementation but now it is pretty standard. >> >> Hmmm, do you mean all changes in this file is not needed? > > I am not sure it is possible, but it would be easier if it was generated and not custom code. Right, we should remove custom setting in CSSProperties.json. Then this could be removed.
Created attachment 451885 [details] Patch
Created attachment 451886 [details] Patch
Created attachment 451887 [details] Patch
Created attachment 451889 [details] Patch
Created attachment 451892 [details] Patch
Created attachment 451904 [details] Patch
<rdar://problem/89028501>
Created attachment 453379 [details] Patch
Created attachment 453399 [details] Patch
Created attachment 453704 [details] Patch
Created attachment 454208 [details] Patch
Created attachment 454323 [details] Patch
Created attachment 456006 [details] Patch
Created attachment 456106 [details] Patch
Created attachment 456113 [details] Patch
Created attachment 457521 [details] Patch
Created attachment 457527 [details] Patch
Created attachment 457985 [details] Patch
Created attachment 458433 [details] Patch
Created attachment 458499 [details] Patch
Created attachment 458859 [details] Patch
Created attachment 459103 [details] Patch
Created attachment 459531 [details] Patch
Created attachment 459570 [details] Patch
Created attachment 459748 [details] Patch
Created attachment 459781 [details] Patch
Created attachment 459785 [details] Patch
Created attachment 460085 [details] Patch
Pull request: https://github.com/WebKit/WebKit/pull/1573
Pull request: https://github.com/WebKit/WebKit/pull/1676
Pull request: https://github.com/WebKit/WebKit/pull/1893
Pull request: https://github.com/WebKit/WebKit/pull/3147
Pull request: https://github.com/WebKit/WebKit/pull/3158
Committed 253768@main (fccee3186739): <https://commits.webkit.org/253768@main> Reviewed commits have been landed. Closing PR #3158 and removing active labels.
Reopening to attach new patch.
Created attachment 461863 [details] Patch
Comment on attachment 461863 [details] Patch How do we check these things with regression tests? Since all tests run with the experimental features enabled, I am not sure we end up testing "content-visibility is fully cleanly disabled by default"
Also, why use the same bug for multiple patches? Not a good system I don’t think.
Created attachment 461878 [details] Patch
Committed 253821@main (827856bf32d2): <https://commits.webkit.org/253821@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461878 [details].
(In reply to Darin Adler from comment #45) > Comment on attachment 461863 [details] > Patch > > How do we check these things with regression tests? Since all tests run with > the experimental features enabled, I am not sure we end up testing > "content-visibility is fully cleanly disabled by default" Not sure if you were addressing me or Sam, but I included a test for this in the patch that landed (content-visibility-invalidate-if-disabled.html).