Bug 236366 - [CMake] Checks uses of execute_process() for correct command splitting
Summary: [CMake] Checks uses of execute_process() for correct command splitting
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
Keywords: InRadar
Depends on:
Reported: 2022-02-09 07:43 PST by Adrian Perez
Modified: 2022-02-15 10:25 PST (History)
15 users (show)

See Also:

Patch (4.41 KB, patch)
2022-02-10 06:48 PST, Adrian Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2022-02-09 07:43:59 PST
I fixed two instances in bug #236365 which were introduced by other of
my recent patches, but there are other uses of execute_process() which
may need a similar treatment:

  % rg -tcmake '\bexecute_process\(' Source/ | wc -l

I am not sure if there are other CMake commands which behave in a similar
way and would be good to check as well.
Comment 1 Adrian Perez 2022-02-10 06:48:33 PST
Created attachment 451524 [details]
Comment 2 Adrian Perez 2022-02-10 06:50:53 PST
(In reply to Adrian Perez from comment #1)
> Created attachment 451524 [details]
> Patch

The rest of uses of execute_process() either take care of properly
splitting command line arguments, or directly specify the command
without gathering multiple arguments from the same variable -- in
the end only two instances of its usage were removed.
Comment 3 EWS 2022-02-15 10:24:53 PST
Committed r289819 (247280@main): <https://commits.webkit.org/247280@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451524 [details].
Comment 4 Radar WebKit Bug Importer 2022-02-15 10:25:19 PST