Bug 236364 - [WebAuthn] Modify getAllLocalAuthenticatorCredentials according to internal needs
Summary: [WebAuthn] Modify getAllLocalAuthenticatorCredentials according to internal n...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: pascoe@apple.com
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-09 07:14 PST by pascoe@apple.com
Modified: 2022-02-15 09:05 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.76 KB, patch)
2022-02-09 07:18 PST, pascoe@apple.com 		no flags Details | Formatted Diff | Diff
Patch (9.57 KB, patch)
2022-02-09 13:47 PST, pascoe@apple.com 		no flags Details | Formatted Diff | Diff
Patch (10.55 KB, patch)
2022-02-09 16:46 PST, pascoe@apple.com 		no flags Details | Formatted Diff | Diff
Patch for landing (10.59 KB, patch)
2022-02-14 09:49 PST, pascoe@apple.com 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description pascoe@apple.com 2022-02-09 07:14:47 PST 
^
Comment 1 pascoe@apple.com 2022-02-09 07:14:58 PST 
rdar://88585418
Comment 2 pascoe@apple.com 2022-02-09 07:18:03 PST 
Created attachment 451371 [details]
Patch
Comment 3 pascoe@apple.com 2022-02-09 13:47:19 PST 
Created attachment 451440 [details]
Patch
Comment 4 pascoe@apple.com 2022-02-09 16:46:11 PST 
Created attachment 451459 [details]
Patch
Comment 5 Brent Fulgham 2022-02-11 10:48:26 PST 
Comment on attachment 451459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451459&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:348
> ++ (void)setUsernameForLocalCredentialWithGroup:(NSString *)group credential:(NSData *)credentialID username: (NSString *)username

Nit: I think we would usually name this something like 'setUsernameForLocalCredentialWithGroupAndID:'

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:553
> ++ (NSData *)exportLocalAuthenticatorCredentialWithGroup:(NSString *)group credential:(NSData *)credentialID error:(NSError **)error

Ditto: "WithGroupAndID"
Comment 6 pascoe@apple.com 2022-02-14 09:49:57 PST 
Created attachment 451918 [details]
Patch for landing
Comment 7 EWS 2022-02-15 09:05:08 PST 
Committed r289817 (247278@main): <https://commits.webkit.org/247278@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451918 [details].