Bug 236355 - Allow hanging run-javascriptcore-tests to print backtrace
Summary: Allow hanging run-javascriptcore-tests to print backtrace
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Angelos Oikonomopoulos
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-09 02:06 PST by Angelos Oikonomopoulos
Modified: 2022-02-09 06:59 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.39 KB, patch)
2022-02-09 02:10 PST, Angelos Oikonomopoulos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Angelos Oikonomopoulos 2022-02-09 02:06:59 PST 
Allow hanging run-javascriptcore-tests to print backtrace
Comment 1 Angelos Oikonomopoulos 2022-02-09 02:10:05 PST 
Created attachment 451350 [details]
Patch
Comment 2 Aakash Jain 2022-02-09 04:12:17 PST 
I'm interested in seeing how the output looks like in practice when sigtermTime is used. Do you have an example, maybe from ews?
Comment 3 Angelos Oikonomopoulos 2022-02-09 04:20:03 PST 
(In reply to Aakash Jain from comment #2)
> I'm interested in seeing how the output looks like in practice when
> sigtermTime is used. Do you have an example, maybe from ews?

Sure! See jscore-test in https://ews-build.webkit.org/#/builders/45/builds/9028.
Comment 4 Aakash Jain 2022-02-09 05:22:01 PST 
Comment on attachment 451350 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451350&action=review

> Tools/CISupport/build-webkit-org/steps.py:467
> +        if 'sigtermTime' not in kwargs:

Not sure if you had specific reason for guarding with this if condition, could have skipped if condition as well. Either way is fine though.
Comment 5 Angelos Oikonomopoulos 2022-02-09 05:42:52 PST 
No specific reason, just allowing the caller to override the value if necessary.
Comment 6 EWS 2022-02-09 06:58:12 PST 
Committed r289468 (247011@main): <https://commits.webkit.org/247011@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451350 [details].
Comment 7 Radar WebKit Bug Importer 2022-02-09 06:59:16 PST 
<rdar://problem/88687428>