Bug 236343 - Non-unified build fixes after r289247
Summary: Non-unified build fixes after r289247
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-08 18:21 PST by Lauro Moura
Modified: 2022-02-09 07:28 PST (History)
17 users (show)

See Also:

Attachments
Patch (11.10 KB, patch)
2022-02-08 18:22 PST, Lauro Moura 		no flags Details | Formatted Diff | Diff
rebased patch (10.25 KB, patch)
2022-02-08 18:32 PST, Lauro Moura 		no flags Details | Formatted Diff | Diff
Patch for landing (10.16 KB, patch)
2022-02-09 05:27 PST, Lauro Moura 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2022-02-08 18:21:50 PST 
Non-unified build fixes after r289247
Comment 1 Lauro Moura 2022-02-08 18:22:52 PST 
Created attachment 451332 [details]
Patch
Comment 2 Lauro Moura 2022-02-08 18:26:56 PST 
Comment on attachment 451332 [details]
Patch

Needs rebase
Comment 3 Lauro Moura 2022-02-08 18:32:10 PST 
Created attachment 451333 [details]
rebased patch
Comment 4 Fujii Hironori 2022-02-08 20:14:06 PST 
Comment on attachment 451333 [details]
rebased patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451333&action=review

> Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp:36
>  #include <WebCore/RegistrableDomain.h>

You add <WebCore/RegistrableDomain.h> in WebSharedWorkerServer.h. We can remove  <WebCore/RegistrableDomain.h> here too.

> Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.h:35
> +#include <pal/SessionID.h>

Do you need to include this? If so, you should remove the forward declaration of SessionID below.
Comment 5 Fujii Hironori 2022-02-08 20:19:37 PST 
Comment on attachment 451333 [details]
rebased patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451333&action=review

> Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.h:32
> +#include <WebCore/TransferredMessagePort.h>

TransferredMessagePort is used only in arguments. I think we should add a forward declaration in this case.
Comment 6 Lauro Moura 2022-02-09 05:27:27 PST 
Created attachment 451361 [details]
Patch for landing
Comment 7 Lauro Moura 2022-02-09 05:30:50 PST 
(In reply to Fujii Hironori from comment #5)
> Comment on attachment 451333 [details]
> rebased patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=451333&action=review
> 
> > Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.h:32
> > +#include <WebCore/TransferredMessagePort.h>
> 
> TransferredMessagePort is used only in arguments. I think we should add a
> forward declaration in this case.

I needed to include it directly as it's an alias to a `std::pair`.
Comment 8 EWS 2022-02-09 07:14:41 PST 
Committed r289469 (247012@main): <https://commits.webkit.org/247012@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451361 [details].
Comment 9 Radar WebKit Bug Importer 2022-02-09 07:15:30 PST 
<rdar://problem/88688041>