Bug 236342 - Apply default sandbox to webpushd on Mac
Summary: Apply default sandbox to webpushd on Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Nham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-08 16:48 PST by Ben Nham
Modified: 2022-02-10 12:14 PST (History)
9 users (show)

See Also:


Attachments
Patch (21.25 KB, patch)
2022-02-08 16:56 PST, Ben Nham
no flags Details | Formatted Diff | Diff
Patch (20.72 KB, patch)
2022-02-08 17:19 PST, Ben Nham
no flags Details | Formatted Diff | Diff
Patch for landing (20.54 KB, patch)
2022-02-10 10:10 PST, Ben Nham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Nham 2022-02-08 16:48:08 PST
Apply default sandbox to webpushd on Mac
Comment 1 Ben Nham 2022-02-08 16:56:52 PST
Created attachment 451326 [details]
Patch
Comment 2 Ben Nham 2022-02-08 17:19:35 PST
Created attachment 451328 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2022-02-08 20:29:26 PST
<rdar://problem/88668389>
Comment 4 Per Arne Vollan 2022-02-10 09:41:32 PST
Comment on attachment 451328 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451328&action=review

R=me.

> Source/WebKit/webpushd/WebPushDaemonMain.mm:95
> +        applySandbox();

It might be good to apply the sandbox first thing in WebPushDaemonMain to avoid establishing connections to services which are blocked by the sandbox.
Comment 5 Ben Nham 2022-02-10 10:10:23 PST
Created attachment 451562 [details]
Patch for landing
Comment 6 EWS 2022-02-10 12:14:37 PST
Committed r289566 (247086@main): <https://commits.webkit.org/247086@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451562 [details].