Bug 23633 - The test transitions/transition-end-event-nested.html occasionally fails
Summary: The test transitions/transition-end-event-nested.html occasionally fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Scott Violet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-29 17:09 PST by Scott Violet
Modified: 2009-02-02 11:13 PST (History)
0 users

See Also:

Attachments
Fix (2.94 KB, patch)
2009-01-29 17:19 PST, Scott Violet 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Violet 2009-01-29 17:09:31 PST 
At least on Chromium debug builds. I suspect this is because some times the timeout is called before the events finish.
Comment 1 Scott Violet 2009-01-29 17:19:14 PST 
Created attachment 27171 [details]
Fix

This patch does two things:

1. Ups the timeout to 2 seconds.
2. Makes test exit as soon as all events are received.

With 2 the tests should be able to run as fast as possible.
Comment 2 Darin Adler 2009-01-30 10:36:49 PST 
Comment on attachment 27171 [details]
Fix

Looks OK as is. But also, if we hit the timeout, then I'd like to see the test fail more directly rather than just calling processEndEvents.

r=me
Comment 3 Darin Fisher (:fishd, Google) 2009-02-02 11:13:06 PST 
http://trac.webkit.org/changeset/40480