Bug 236327 - Invoke generate-xcfilelists with Python 3
Summary: Invoke generate-xcfilelists with Python 3
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-08 14:23 PST by Elliott Williams
Modified: 2022-02-10 15:08 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.98 KB, patch)
2022-02-08 14:24 PST, Elliott Williams
emw: review-
Details | Formatted Diff | Diff
python -> python3 in WebKit.xcodeproj, build scripts (3.58 KB, patch)
2022-02-09 20:02 PST, Elliott Williams
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2022-02-08 14:23:44 PST
Use of unversioned 'python' in Mac builds causing failures in 12.3
Comment 1 Elliott Williams 2022-02-08 14:24:49 PST
Created attachment 451303 [details]
Patch
Comment 2 Elliott Williams 2022-02-08 14:25:56 PST
Comment on attachment 451303 [details]
Patch

I still need to test this in the latest 12.3 beta seed before this is ready to land.
Comment 3 Radar WebKit Bug Importer 2022-02-08 14:26:59 PST
<rdar://problem/88652152>
Comment 4 Elliott Williams 2022-02-08 20:36:15 PST
Unfortunately, this will take some more work. The next script to fail (on my machine) is JavaScriptCore's "Check .xcfilelists". Fixing its shebang doesn't suffice, it still fails with

	PhaseScriptExecution Check\ .xcfilelists /Volumes/Data/OpenSource/WebKitBuild/JavaScriptCore.build/Debug/JavaScriptCore.build/Script-53609F9021DFFA9C008FA60A.sh
	    cd /Volumes/Data/OpenSource/Source/JavaScriptCore
	    /bin/sh -c /Volumes/Data/OpenSource/WebKitBuild/JavaScriptCore.build/Debug/JavaScriptCore.build/Script-53609F9021DFFA9C008FA60A.sh
	Traceback (most recent call last):
	  File "/Volumes/Data/Internal/Tools/Scripts/../../../OpenSource/Tools/Scripts/generate-xcfilelists", line 59, in <module>
	    application_class = apple_additions().get_generate_xcfilelists_application() if apple_additions() else Application
	  File "/Volumes/Data/Internal/Tools/Scripts/apple_additions/__init__.py", line 129, in get_generate_xcfilelists_application
	    from apple_additions.generate_xcfilelists_internal_application import InternalApplication
	  File "/Volumes/Data/Internal/Tools/Scripts/apple_additions/generate_xcfilelists_internal_application.py", line 7, in <module>
	    import generate_xcfilelists_internal_generators as Generators
	ModuleNotFoundError: No module named 'generate_xcfilelists_internal_generators'
	Command /bin/sh failed with exit code 1


Perhaps there are some actual python2 dependencies in this library :\
Comment 5 Elliott Williams 2022-02-09 20:02:50 PST
Created attachment 451489 [details]
python -> python3 in WebKit.xcodeproj, build scripts

Updates shebang lines for a couple of scripts needed to make internal builds.
Comment 6 Elliott Williams 2022-02-10 11:46:22 PST
Comment on attachment 451489 [details]
python -> python3 in WebKit.xcodeproj, build scripts

`build-jsc` works locally, so I think the failure was a flake. cq+
Comment 7 EWS 2022-02-10 15:08:33 PST
Committed r289584 (247099@main): <https://commits.webkit.org/247099@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451489 [details].