Bug 236327 – Invoke generate-xcfilelists with Python 3

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Elliott Williams]

Use of unversioned 'python' in Mac builds causing failures in 12.3

[Elliott Williams]

Created attachment 451303 [details]
Patch

[Elliott Williams]

Comment on attachment 451303 [details]
Patch

I still need to test this in the latest 12.3 beta seed before this is ready to land.

[Radar WebKit Bug Importer]

<rdar://problem/88652152>

[Elliott Williams]

Unfortunately, this will take some more work. The next script to fail (on my machine) is JavaScriptCore's "Check .xcfilelists". Fixing its shebang doesn't suffice, it still fails with

	PhaseScriptExecution Check\ .xcfilelists /Volumes/Data/OpenSource/WebKitBuild/JavaScriptCore.build/Debug/JavaScriptCore.build/Script-53609F9021DFFA9C008FA60A.sh
	    cd /Volumes/Data/OpenSource/Source/JavaScriptCore
	    /bin/sh -c /Volumes/Data/OpenSource/WebKitBuild/JavaScriptCore.build/Debug/JavaScriptCore.build/Script-53609F9021DFFA9C008FA60A.sh
	Traceback (most recent call last):
	  File "/Volumes/Data/Internal/Tools/Scripts/../../../OpenSource/Tools/Scripts/generate-xcfilelists", line 59, in <module>
	    application_class = apple_additions().get_generate_xcfilelists_application() if apple_additions() else Application
	  File "/Volumes/Data/Internal/Tools/Scripts/apple_additions/__init__.py", line 129, in get_generate_xcfilelists_application
	    from apple_additions.generate_xcfilelists_internal_application import InternalApplication
	  File "/Volumes/Data/Internal/Tools/Scripts/apple_additions/generate_xcfilelists_internal_application.py", line 7, in <module>
	    import generate_xcfilelists_internal_generators as Generators
	ModuleNotFoundError: No module named 'generate_xcfilelists_internal_generators'
	Command /bin/sh failed with exit code 1


Perhaps there are some actual python2 dependencies in this library :\

[Elliott Williams]

Created attachment 451489 [details]
python -> python3 in WebKit.xcodeproj, build scripts

Updates shebang lines for a couple of scripts needed to make internal builds.

[Elliott Williams]

Comment on attachment 451489 [details]
python -> python3 in WebKit.xcodeproj, build scripts

`build-jsc` works locally, so I think the failure was a flake. cq+

[EWS]

Committed r289584 (247099@main): <https://commits.webkit.org/247099@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451489 [details].