Bug 236318 – Don't return an empty value from AbortController.signal.reason and make it harder to return empty values from JSValueInWrappedObject

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

<rdar://88580935>

[Radar WebKit Bug Importer]

<rdar://problem/88643006>

[Saam Barati]

Created attachment 451336 [details]
patch

[Mark Lam]

Comment on attachment 451336 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451336&action=review

> Source/WebCore/bindings/js/JSValueInWrappedObject.h:-47
> -    operator JSC::JSValue() const;

Maybe make this private so that the compiler complains if someone tries to cast?

> Source/WebCore/bindings/js/JSValueInWrappedObject.h:83
> +    if (m_nonCell)
> +        return true;
> +    return !!m_cell;

You can express this as:
    return m_nonCell || m_cell;

[Mark Lam]

Comment on attachment 451336 [details]
patch

r=me

[Saam Barati]

Created attachment 451337 [details]
patch for landing

[Saam Barati]

Created attachment 451338 [details]
patch for landing

[EWS]

Committed r289462 (247005@main): <https://commits.webkit.org/247005@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451338 [details].