RESOLVED FIXED 236309
Register strings in CSSTokenizer created from preprocessing 
https://bugs.webkit.org/show_bug.cgi?id=236309
Summary Register strings in CSSTokenizer created from preprocessing
Gabriel Nava Marino
Reported 2022-02-08 09:43:00 PST
This will align with what is currently done for strings with escapes in CSSTokenizer::consumeName().
Attachments
Patch (5.74 KB, patch)
2022-02-08 09:46 PST, Gabriel Nava Marino 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gabriel Nava Marino
Comment 1 2022-02-08 09:46:04 PST
<rdar://problem/88321921>
Gabriel Nava Marino
Comment 2 2022-02-08 09:46:49 PST
Created attachment 451262 [details] Patch
Sam Weinig
Comment 3 2022-02-08 10:00:16 PST
Comment on attachment 451262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451262&action=review > Source/WebCore/ChangeLog:9 > + Register strings in CSSTokenizer created from preprocessing. This will align with > + what is currently done for strings with escapes in CSSTokenizer::consumeName(). What is the benefit of this change?
Gabriel Nava Marino
Comment 4 2022-02-08 10:17:30 PST
(In reply to Sam Weinig from comment #3) > Comment on attachment 451262 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=451262&action=review > > > Source/WebCore/ChangeLog:9 > > + Register strings in CSSTokenizer created from preprocessing. This will align with > > + what is currently done for strings with escapes in CSSTokenizer::consumeName(). > > What is the benefit of this change? Otherwise the string can go out of scope.
EWS
Comment 5 2022-02-09 11:40:26 PST
Committed r289493 (247031@main): <https://commits.webkit.org/247031@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451262 [details].
Note You need to log in before you can comment on or make changes to this bug.