Bug 236309 - Register strings in CSSTokenizer created from preprocessing
Summary: Register strings in CSSTokenizer created from preprocessing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gabriel Nava Marino
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-08 09:43 PST by Gabriel Nava Marino
Modified: 2022-02-09 11:40 PST (History)
9 users (show)

See Also:

Attachments
Patch (5.74 KB, patch)
2022-02-08 09:46 PST, Gabriel Nava Marino 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel Nava Marino 2022-02-08 09:43:00 PST 
This will align with what is currently done for strings with escapes in CSSTokenizer::consumeName().
Comment 1 Gabriel Nava Marino 2022-02-08 09:46:04 PST 
<rdar://problem/88321921>
Comment 2 Gabriel Nava Marino 2022-02-08 09:46:49 PST 
Created attachment 451262 [details]
Patch
Comment 3 Sam Weinig 2022-02-08 10:00:16 PST 
Comment on attachment 451262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451262&action=review

> Source/WebCore/ChangeLog:9
> +        Register strings in CSSTokenizer created from preprocessing. This will align with
> +        what is currently done for strings with escapes in CSSTokenizer::consumeName().

What is the benefit of this change?
Comment 4 Gabriel Nava Marino 2022-02-08 10:17:30 PST 
(In reply to Sam Weinig from comment #3)
> Comment on attachment 451262 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=451262&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        Register strings in CSSTokenizer created from preprocessing. This will align with
> > +        what is currently done for strings with escapes in CSSTokenizer::consumeName().
> 
> What is the benefit of this change?

Otherwise the string can go out of scope.
Comment 5 EWS 2022-02-09 11:40:26 PST 
Committed r289493 (247031@main): <https://commits.webkit.org/247031@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451262 [details].