Bug 236308 - [LFC][Integration] LineIteratorModernPath::baselineType should consult Display::Line
Summary: [LFC][Integration] LineIteratorModernPath::baselineType should consult Displa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-08 09:28 PST by zalan
Modified: 2022-02-08 13:48 PST (History)
5 users (show)

See Also:

Attachments
Patch (10.90 KB, patch)
2022-02-08 09:44 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-02-08 09:28:17 PST 
ssia
Comment 1 zalan 2022-02-08 09:44:18 PST 
Created attachment 451261 [details]
Patch
Comment 2 Antti Koivisto 2022-02-08 09:55:48 PST 
Comment on attachment 451261 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451261&action=review

> Source/WebCore/layout/integration/LayoutIntegrationLine.h:39
> +    Line(size_t firstBoxIndex, size_t boxCount, const FloatRect& lineBoxRect, float enclosingContentTop, float enclosingContentBottom, const FloatRect& scrollableOverflow, const FloatRect& inkOverflow, float baseline, FontBaseline baselineType, float contentLeft, float contentLogicalWidth)

OMG we still have this
Comment 3 zalan 2022-02-08 09:59:08 PST 
yeah we do :(
Comment 4 EWS 2022-02-08 13:47:12 PST 
Committed r289425 (246985@main): <https://commits.webkit.org/246985@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451261 [details].
Comment 5 Radar WebKit Bug Importer 2022-02-08 13:48:17 PST 
<rdar://problem/88650129>