Bug 236305 - ImageBuffer::get/putPixelBuffer should not go through DisplayList
Summary: ImageBuffer::get/putPixelBuffer should not go through DisplayList
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on: 236744 240802
Blocks:
  Show dependency tree / graph
 
Reported: 2022-02-08 08:31 PST by Kimmo Kinnunen
Modified: 2022-06-09 00:46 PDT (History)
8 users (show)

See Also:

Attachments
Patch (51.24 KB, patch)
2022-02-08 08:59 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2022-02-08 08:31:04 PST 
ImageBuffer::get/putPixelBuffer should not go through DisplayList
Comment 1 Kimmo Kinnunen 2022-02-08 08:59:20 PST 
Created attachment 451256 [details]
Patch
Comment 2 Sam Weinig 2022-02-08 10:06:29 PST 
Comment on attachment 451256 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451256&action=review

> Source/WebCore/ChangeLog:9
> +        Remove GetPixelBuffer / PutPixelBuffer from display list implementation.
> +        Display lists are about GraphicsContext commands.

Awesome!
Comment 3 Geoffrey Garen 2022-02-08 10:16:29 PST 
Comment on attachment 451256 [details]
Patch

r=me

Any way to add a test for the inverted references case?
Comment 4 Kimmo Kinnunen 2022-02-08 11:05:13 PST 
(In reply to Geoffrey Garen from comment #3)
> Comment on attachment 451256 [details]
> Patch
> 
> r=me
> 
> Any way to add a test for the inverted references case?

Currently there's no such things, as read and write references are not tracked in that way. I'm working on adding these after https://bugs.webkit.org/show_bug.cgi?id=236099
Comment 5 Radar WebKit Bug Importer 2022-02-09 22:10:39 PST 
<rdar://problem/88735790>
Comment 6 EWS 2022-02-10 14:50:13 PST 
Committed r289580 (247097@main): <https://commits.webkit.org/247097@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451256 [details].