Bug 23630 - Codereview: Skia complex font rendering
Summary: Codereview: Skia complex font rendering
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Sverrir Á. Berg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-29 15:40 PST by Sverrir Á. Berg
Modified: 2009-02-10 00:34 PST (History)
2 users (show)

See Also:

Attachments
Patch (21.39 KB, patch)
2009-01-29 15:42 PST, Sverrir Á. Berg 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sverrir Á. Berg 2009-01-29 15:40:44 PST 
Add complex font rendering using Skia instead of Windows ScriptTextOut.  This adds support for enhanced webkit styles when drawing complex glyphs.
Comment 1 Sverrir Á. Berg 2009-01-29 15:42:51 PST 
Created attachment 27168 [details]
Patch
Comment 2 Eric Seidel (no email) 2009-01-29 16:06:58 PST 
I'd like to see Brett's comments on this before any of us WebKit dev's r+ this.  (maybe brett has already reviewed this in chromium's repo?)
Comment 3 Brett Wilson (Google) 2009-01-29 22:13:32 PST 
I already reviewed this. I don't think it's a complete solution for complex scripts and effects, but is better than what we have now and should cover 90% of the cases.
Comment 4 Sverrir Á. Berg 2009-02-05 11:34:38 PST 
ping?
Comment 5 Eric Seidel (no email) 2009-02-05 11:39:04 PST 
Comment on attachment 27168 [details]
Patch

Brett likes it.  It's fine with me.
Comment 6 Sverrir Á. Berg 2009-02-06 11:36:51 PST 
Eric: Could you please land/commit this for me?

Thanks,
Sverrir
Comment 7 Darin Fisher (:fishd, Google) 2009-02-10 00:34:42 PST 
Landed here:
http://trac.webkit.org/changeset/40812