Bug 236296 – DisplayListRecorder implementations are not able to obtain extra information out of source ImageBuffers

• Status: RESOLVED
• Resolution: FIXED
• Component: Canvas

[Kimmo Kinnunen]

DisplayListRecorder implementations are not able to obtain extra information out of source ImageBitmaps

[Kimmo Kinnunen]

Created attachment 451233 [details]
Patch

[Said Abou-Hallawa]

Comment on attachment 451233 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451233&action=review

> Source/WebCore/ChangeLog:3
> +        DisplayListRecorder implementations are not able to obtain extra information out of source ImageBitmaps

I think you meant ImageBuffer since ImageBitmap is a class used for offscreen canvas.

> Source/WebCore/ChangeLog:8
> +        Pass ImageBitmap& to various recording commands instead of the resource identifier.

Pass ImageBuffer...

> Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:162
> -        recordDrawFilteredImageBuffer({ }, sourceImageRect, filter);
> +        recordDrawFilteredImageBuffer(sourceImageRect, filter);

Why do we have two versions of recordDrawFilteredImageBuffer()? Can't we have one which takes ImageBuffer*. Some filter effects like <feFlood> do not require sourceImage and this is why it is a pointer.

[Kimmo Kinnunen]

Created attachment 451351 [details]
Patch for landing

[Kimmo Kinnunen]

(In reply to Said Abou-Hallawa from comment #2)
> I think you meant ImageBuffer since ImageBitmap is a class used for
> offscreen canvas.

> Pass ImageBuffer...

> 
> Why do we have two versions of recordDrawFilteredImageBuffer()? Can't we
> have one which takes ImageBuffer*. Some filter effects like <feFlood> do not
> require sourceImage and this is why it is a pointer.

Thank for looking, changed.

[Kimmo Kinnunen]

Created attachment 451355 [details]
Patch for landing

[EWS]

Committed r289492 (247030@main): <https://commits.webkit.org/247030@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451355 [details].

[Radar WebKit Bug Importer]

<rdar://problem/88704119>