Bug 236295 - [WPE] Developer extras are always enabled by default
Summary: [WPE] Developer extras are always enabled by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-08 02:49 PST by Adrian Perez
Modified: 2022-02-08 04:33 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.34 KB, patch)
2022-02-08 03:00 PST, Adrian Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2022-02-08 02:49:45 PST 
Currently in WPEView.cpp there is a call to enable the option unconditionally,
around line 64:

    if (preferences) {
        preferences->setAcceleratedCompositingEnabled(true);
        preferences->setForceCompositingMode(true);
        preferences->setThreadedScrollingEnabled(true);
        preferences->setWebGLEnabled(true);
        preferences->setDeveloperExtrasEnabled(true);
    }

This should be disabled by default, and when needed users would opt-in with
webkit_settings_set_enable_developer_extras(settings, TRUE) via the public
API.
Comment 1 Adrian Perez 2022-02-08 03:00:10 PST 
Created attachment 451229 [details]
Patch
Comment 2 EWS 2022-02-08 04:33:24 PST 
Committed r289366 (246954@main): <https://commits.webkit.org/246954@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451229 [details].