Bug 236292 - Settling of a fetch promise should be delayed in case page is entering page cache
Summary: Settling of a fetch promise should be delayed in case page is entering page c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-08 02:31 PST by youenn fablet
Modified: 2022-02-10 07:46 PST (History)
9 users (show)

See Also:

Attachments
Patch (11.66 KB, patch)
2022-02-08 02:49 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (12.74 KB, patch)
2022-02-08 06:10 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (71.01 KB, patch)
2022-02-08 07:34 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (12.85 KB, patch)
2022-02-08 08:13 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2022-02-08 02:31:56 PST 
<rdar://88452971>
Comment 1 youenn fablet 2022-02-08 02:49:00 PST 
Created attachment 451227 [details]
Patch
Comment 2 youenn fablet 2022-02-08 06:10:59 PST 
Created attachment 451239 [details]
Patch
Comment 3 youenn fablet 2022-02-08 07:34:46 PST 
Created attachment 451244 [details]
Patch
Comment 4 youenn fablet 2022-02-08 08:13:44 PST 
Created attachment 451250 [details]
Patch
Comment 5 Chris Dumez 2022-02-08 11:38:50 PST 
Comment on attachment 451250 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451250&action=review

r=me

> Source/WebCore/Modules/fetch/FetchResponse.cpp:352
> +        responseCallback(Ref { m_response });

Why the Ref { }?
Comment 6 youenn fablet 2022-02-10 07:39:39 PST 
(In reply to Chris Dumez from comment #5)
> Comment on attachment 451250 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=451250&action=review
> 
> r=me
> 
> > Source/WebCore/Modules/fetch/FetchResponse.cpp:352
> > +        responseCallback(Ref { m_response });
> 
> Why the Ref { }?

responseCallback takes an ExceptionOr<Ref<>>.
Comment 7 EWS 2022-02-10 07:46:24 PST 
Committed r289533 (247064@main): <https://commits.webkit.org/247064@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451250 [details].