RESOLVED FIXED 23628
Fix selection painting to do container-relative repaints 
https://bugs.webkit.org/show_bug.cgi?id=23628
Summary Fix selection painting to do container-relative repaints
Simon Fraser (smfr)
Reported 2009-01-29 15:36:00 PST
Selection currently repaints via the view. This needs to be fixed to make repaints container-relative.
Attachments
Patch, changelog. (35.95 KB, patch)
2009-02-03 17:48 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (25.16 KB, patch)
2009-12-03 15:34 PST, mitz 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2009-02-03 17:48:58 PST
Created attachment 27305 [details] Patch, changelog.
Dave Hyatt
Comment 2 2009-02-03 18:12:42 PST
Comment on attachment 27305 [details] Patch, changelog. r=me Run pixel tests before landing this, since that's the only way to see some of this in action.
Simon Fraser (smfr)
Comment 3 2009-02-03 18:42:00 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/GNUmakefile.am M WebCore/WebCore.vcproj/WebCore.vcproj M WebCore/WebCore.xcodeproj/project.pbxproj M WebCore/rendering/RenderBR.h M WebCore/rendering/RenderBlock.cpp M WebCore/rendering/RenderBlock.h M WebCore/rendering/RenderListMarker.cpp M WebCore/rendering/RenderListMarker.h M WebCore/rendering/RenderObject.h M WebCore/rendering/RenderReplaced.cpp M WebCore/rendering/RenderReplaced.h M WebCore/rendering/RenderSVGInlineText.cpp M WebCore/rendering/RenderSVGInlineText.h A WebCore/rendering/RenderSelectionInfo.h M WebCore/rendering/RenderText.cpp M WebCore/rendering/RenderText.h M WebCore/rendering/RenderView.cpp M WebCore/rendering/RenderView.h M WebCore/rendering/RenderWidget.cpp Committed r40564
Simon Fraser (smfr)
Comment 4 2009-02-03 18:42:34 PST
Comment on attachment 27305 [details] Patch, changelog. Landed in r40564. Keeping open to fix RenderBlock::selectionGapRectsForRepaint()
Simon Fraser (smfr)
Comment 5 2009-02-06 20:10:07 PST
Comment on attachment 27305 [details] Patch, changelog. Getting out of the 'patches to land' queue.
Simon Fraser (smfr)
Comment 6 2009-11-20 13:54:28 PST
<rdar://problem/7401617>
mitz
Comment 7 2009-12-03 15:34:13 PST
Created attachment 44272 [details] Patch
WebKit Review Bot
Comment 8 2009-12-03 15:35:39 PST
style-queue ran check-webkit-style on attachment 44272 [details] without any errors.
mitz
Comment 9 2009-12-03 16:19:21 PST
Comment on attachment 44272 [details] Patch Committed http://trac.webkit.org/projects/webkit/changeset/51668
Simon Fraser (smfr)
Comment 10 2010-01-22 20:09:03 PST
Fixed in http://trac.webkit.org/changeset/51776 and http://trac.webkit.org/changeset/51668
Note You need to log in before you can comment on or make changes to this bug.