Bug 236278 - IDBRequest should emit write barrier on JSValueInWrappedObject modification
Summary: IDBRequest should emit write barrier on JSValueInWrappedObject modification
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Website Storage (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-07 19:35 PST by Yusuke Suzuki
Modified: 2023-02-09 11:24 PST (History)
9 users (show)

See Also:

Attachments
Patch (10.53 KB, patch)
2022-02-08 16:12 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch for landing (10.53 KB, patch)
2022-02-09 23:29 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2022-02-07 19:35:43 PST 
https://bugs.webkit.org/show_bug.cgi?id=194806 introduced JSValueInWrappedObject assignment, but this is not correct in terms of semantics since we are not emitting a write-barrier.
So, these fields can be collected by concurrent GC.
See https://bugs.webkit.org/show_bug.cgi?id=236277's FIXME comment for more detail.
Comment 1 Sihui Liu 2022-02-08 16:12:06 PST 
Created attachment 451319 [details]
Patch
Comment 2 Geoffrey Garen 2022-02-09 09:49:01 PST 
Comment on attachment 451319 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451319&action=review

r=me

> Source/WebCore/ChangeLog:15
> +        This has a semantice error as the swap process does not emit write barrier (webkit.org/b/236277). To fix the

semantice => semantic
Comment 3 Sihui Liu 2022-02-09 23:29:46 PST 
Created attachment 451496 [details]
Patch for landing
Comment 4 EWS 2022-02-10 00:18:14 PST 
Committed r289522 (247053@main): <https://commits.webkit.org/247053@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451496 [details].
Comment 5 Radar WebKit Bug Importer 2022-02-10 00:19:19 PST 
<rdar://problem/88740386>
Comment 6 EWS 2023-02-09 11:24:32 PST 
Committed 260073@main (4d3456e83828): <https://commits.webkit.org/260073@main>

Reviewed commits have been landed. Closing PR #9696 and removing active labels.