Bug 236276 - Initialize the AXIsolatedObject AccessibilityText property lazily.
Summary: Initialize the AXIsolatedObject AccessibilityText property lazily.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-07 17:51 PST by Andres Gonzalez
Modified: 2022-02-08 14:15 PST (History)
10 users (show)

See Also:

Attachments
Patch (5.23 KB, patch)
2022-02-07 18:00 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (8.69 KB, patch)
2022-02-08 09:10 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (8.58 KB, patch)
2022-02-08 12:28 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2022-02-07 17:51:42 PST 
Initialize the AXIsolatedObject AccessibilityText property lazily.
Comment 1 Radar WebKit Bug Importer 2022-02-07 17:52:06 PST 
<rdar://problem/88604453>
Comment 2 Andres Gonzalez 2022-02-07 18:00:05 PST 
Created attachment 451186 [details]
Patch
Comment 3 chris fleizach 2022-02-07 19:00:54 PST 
Comment on attachment 451186 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451186&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:1011
> +    Accessibility::performFunctionOnMainThread([&propertyName, this] () {

Can these methods return a variant so we only need one method?
Comment 4 Andres Gonzalez 2022-02-08 09:10:33 PST 
Created attachment 451258 [details]
Patch
Comment 5 Andres Gonzalez 2022-02-08 09:16:13 PST 
(In reply to chris fleizach from comment #3)
> Comment on attachment 451186 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=451186&action=review
> 
> > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:1011
> > +    Accessibility::performFunctionOnMainThread([&propertyName, this] () {
> 
> Can these methods return a variant so we only need one method?

Done.
Comment 6 Andres Gonzalez 2022-02-08 12:28:10 PST 
Created attachment 451294 [details]
Patch
Comment 7 EWS 2022-02-08 14:15:30 PST 
Committed r289427 (246987@main): <https://commits.webkit.org/246987@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451294 [details].