PLATFORM(SKIA) build bustage in SVGPaintServer.cpp

[Darin Fisher (:fishd, Google)]

PLATFORM(SKIA) build bustage in SVGPaintServer.cpp

Simple patch coming up...

[Darin Fisher (:fishd, Google)]

Created attachment 27164 [details]
v1 patch

Comment on attachment 27164 [details]
v1 patch

I wonder if this won't trigger the unused parameters warning on non-Skia platforms.

[Darin Fisher (:fishd, Google)]

Oh, I didn't realize that warning was enabled.  I guess I could move the entire function into the #ifdef.

[Darin Adler]

Comment on attachment 27164 [details]
v1 patch

This will break the build on Mac OS X unless you use UNUSED_PARAM when it's not PLATFORM(SKIA).

[Darin Fisher (:fishd, Google)]

Created attachment 27165 [details]
v2 patch

[Darin Adler]

Comment on attachment 27165 [details]
v2 patch

> +#else
> +void SVGPaintServer::teardown(GraphicsContext*&, const RenderObject*, SVGPaintTargetType, bool) const
> +{
> +#endif

Missing a brace here. Please fix that!

[Darin Fisher (:fishd, Google)]

Created attachment 27167 [details]
v3 patch

3rd times a charm :)

[Eric Seidel (no email)]

I don't understand why this is necessary?  Why doesn't Skia want the standard "teardown" function?  Skia should be using the standard PatternSkia.cpp and GradientSkia.cpp abstractions instead of any custom SVGPaintServer* classes these days...

[Darin Fisher (:fishd, Google)]

That's a great question.  I think the FIXME implies a desire to clean that up.  I was just hoping to "fix bustage" in existing code.  Can I postpone cleanup to a subsequent bug?

[Eric Seidel (no email)]

Comment on attachment 27167 [details]
v3 patch

Oh, I'm sorry.  I thought you were adding the #ifdefs, I didn't realize they were already there.  Yes, this is totally fine.

[Darin Fisher (:fishd, Google)]

http://trac.webkit.org/changeset/40385