Bug 236262 - [JSC] Convert JSString's non-atomic WTF::String to atomic string while concurrent compilers / heap threads run
Summary: [JSC] Convert JSString's non-atomic WTF::String to atomic string while concur...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-07 14:38 PST by Yusuke Suzuki
Modified: 2022-02-07 21:48 PST (History)
8 users (show)

See Also:

Attachments
Patch (16.95 KB, patch)
2022-02-07 14:55 PST, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2022-02-07 14:38:25 PST 
[JSC] Convert JSString's non-atomic WTF::String to atomic string while concurrent compilers / heap threads run
Comment 1 Yusuke Suzuki 2022-02-07 14:55:48 PST 
Created attachment 451156 [details]
Patch
Comment 2 Sam Weinig 2022-02-07 16:35:03 PST 
Comment on attachment 451156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451156&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        [JSC] Convert JSString's non-atomic WTF::String to atomic string while concurrent compilers / heap threads run

Alas, it is now called AtomString, not AtomicString.

> Source/JavaScriptCore/ChangeLog:8
> +        Inspired from Cameron's change. This patch introduces a new protocol which allows us to replace JSString's underlying non-atomic String

Which change are you referring to here (I don't know, and in the future those reading this surely will not know).
Comment 3 Yusuke Suzuki 2022-02-07 17:28:39 PST 
Comment on attachment 451156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451156&action=review

>> Source/JavaScriptCore/ChangeLog:8
>> +        Inspired from Cameron's change. This patch introduces a new protocol which allows us to replace JSString's underlying non-atomic String
> 
> Which change are you referring to here (I don't know, and in the future those reading this surely will not know).

This one https://trac.webkit.org/changeset/289177/webkit.
Comment 4 Saam Barati 2022-02-07 18:10:19 PST 
Comment on attachment 451156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451156&action=review

r=me

>>> Source/JavaScriptCore/ChangeLog:8
>>> +        Inspired from Cameron's change. This patch introduces a new protocol which allows us to replace JSString's underlying non-atomic String
>> 
>> Which change are you referring to here (I don't know, and in the future those reading this surely will not know).
> 
> This one https://trac.webkit.org/changeset/289177/webkit.

I'd link it here in the changelog or just write r289177
Comment 5 Yusuke Suzuki 2022-02-07 21:43:21 PST 
OK, changed :)
Comment 6 Yusuke Suzuki 2022-02-07 21:47:21 PST 
Committed r289359 (246947@trunk): <https://commits.webkit.org/246947@trunk>
Comment 7 Radar WebKit Bug Importer 2022-02-07 21:48:21 PST 
<rdar://problem/88611548>