Bug 236251 - [Xcode] Prevent install builds from using the default toolchain
Summary: [Xcode] Prevent install builds from using the default toolchain
Status: RESOLVED MOVED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-07 12:09 PST by Elliott Williams
Modified: 2022-02-07 13:32 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.61 KB, patch)
2022-02-07 12:14 PST, Elliott Williams 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2022-02-07 12:09:49 PST 
[Xcode] Prevent install builds from using the default toolchain
Comment 1 Elliott Williams 2022-02-07 12:14:12 PST 
Created attachment 451137 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2022-02-07 12:15:13 PST 
<rdar://problem/88587680>
Comment 3 Elliott Williams 2022-02-07 12:17:22 PST 
Comment on attachment 451137 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451137&action=review

> Source/WTF/WTF.xcodeproj/project.pbxproj:1761
> +			shellScript = "if [ $(basename \"$TOOLCHAIN_DIR\") == \"XcodeDefault.xctoolchain\" ]; then\necho \"error: Installed toolchain doesn't match requested one, failing the build early to prevent falling back to default toolchain\"\nexit 1\nfi\n";

this is:
```
if [ $(basename "$TOOLCHAIN_DIR") == "XcodeDefault.xctoolchain" ]; then
echo "error: Installed toolchain doesn't match requested one, failing the build early to prevent falling back to default toolchain"
exit 1
fi
```
Comment 4 Alexey Proskuryakov 2022-02-07 13:32:29 PST 
Comment on attachment 451137 [details]
Patch

Moving this elsewhere.