Bug 236250 – Prevent removal of isolated objects from a different parent than the current parent.

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Andres Gonzalez]

Prevent removal of isolated objects from a different parent than the current parent.

[Radar WebKit Bug Importer]

<rdar://problem/88585928>

[Andres Gonzalez]

Created attachment 451133 [details]
Patch

[chris fleizach]

Comment on attachment 451133 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451133&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:499
> +    if (axParentID != m_nodeMap.get(axID).parentID) {

will this cause a problem from the root node that has no parent?

[Tyler Wilcock]

Comment on attachment 451133 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451133&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:500
> +        AXLOG(makeString("Removing object from a different parent ", axParentID.loggingString(), ", actual parent ", m_nodeMap.get(axID).parentID.loggingString(), ", bailing out."));

Starting the log message with "Removing object" implies that we are actually going through with this operation. Maybe instead it could read something like:

"Attempted to remove object from a different parent (ID 123) than its node map parent (ID 321). Bailing out."

[chris fleizach]

m_nodeMap now references an ID and a struct with the parentID and childIds

Why do we need the struct in m_nodePa if the key is already the parentID?

[Andres Gonzalez]

Created attachment 451142 [details]
Patch

[Andres Gonzalez]

(In reply to chris fleizach from comment #3)
> Comment on attachment 451133 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=451133&action=review
> 
> > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:499
> > +    if (axParentID != m_nodeMap.get(axID).parentID) {
> 
> will this cause a problem from the root node that has no parent?

No, because in that case both axParentID and  m_nodeMap.get(objectID).parentID should be 0.

[Andres Gonzalez]

(In reply to Tyler Wilcock from comment #4)
> Comment on attachment 451133 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=451133&action=review
> 
> > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:500
> > +        AXLOG(makeString("Removing object from a different parent ", axParentID.loggingString(), ", actual parent ", m_nodeMap.get(axID).parentID.loggingString(), ", bailing out."));
> 
> Starting the log message with "Removing object" implies that we are actually
> going through with this operation. Maybe instead it could read something
> like:
> 
> "Attempted to remove object from a different parent (ID 123) than its node
> map parent (ID 321). Bailing out."

Done: "Tried to remove..."

[Andres Gonzalez]

(In reply to chris fleizach from comment #5)
> m_nodeMap now references an ID and a struct with the parentID and childIds
> 
> Why do we need the struct in m_nodePa if the key is already the parentID?

The key is the object ID, the struct stores its parent ID and children IDs. Fixed up the comments a bit and the variable naming to make it more evident.

[EWS]

Committed r289355 (246943@main): <https://commits.webkit.org/246943@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451142 [details].