Bug 236249 - Update hover state based on pointer type.
Summary: Update hover state based on pointer type.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-07 11:25 PST by Megan Gardner
Modified: 2022-02-07 15:19 PST (History)
10 users (show)

See Also:


Attachments
Patch (15.07 KB, patch)
2022-02-07 11:28 PST, Megan Gardner
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (15.08 KB, patch)
2022-02-07 12:18 PST, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch for landing (14.63 KB, patch)
2022-02-07 14:28 PST, Megan Gardner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2022-02-07 11:25:40 PST
Update hover state based on pointer type.
Comment 1 Megan Gardner 2022-02-07 11:28:18 PST
Created attachment 451128 [details]
Patch
Comment 2 Megan Gardner 2022-02-07 12:18:14 PST
Created attachment 451138 [details]
Patch
Comment 3 Tim Horton 2022-02-07 14:07:50 PST
Comment on attachment 451138 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451138&action=review

> Source/WebCore/dom/Element.h:346
> +    virtual void setHovered(bool = true, Style::InvalidationScope = Style::InvalidationScope::All, HitTestRequest = HitTestRequest());

{ }

> Source/WebCore/html/HTMLTextFormControlElement.cpp:73
> +    UNUSED_PARAM(request);

can just drop the argument names instead of UNUSED_PARAM (applies in a bunch of places)

> Source/WebCore/html/HTMLTextFormControlElement.cpp:128
> +    // Update our status first.

Do not think this comment is necessary (maybe if it said why, but since it doesn't, get rid of it).

> Source/WebKit/UIProcess/ios/WKMouseGestureRecognizer.mm:148
> +- (bool)checkTouches:(NSSet<UITouch *> *)touches

Don't think you need this anymore?
Comment 4 Megan Gardner 2022-02-07 14:28:12 PST
Created attachment 451152 [details]
Patch for landing
Comment 5 EWS 2022-02-07 15:18:47 PST
Committed r289246 (246930@main): <https://commits.webkit.org/246930@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451152 [details].
Comment 6 Radar WebKit Bug Importer 2022-02-07 15:19:16 PST
<rdar://problem/88597170>