Bug 236244 - No animation when scroll snap scroller is navigated with the keyboard
Summary: No animation when scroll snap scroller is navigated with the keyboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: BrowserCompat, InRadar
Depends on:
Blocks:
 
Reported: 2022-02-07 08:49 PST by Simon Fraser (smfr)
Modified: 2022-02-28 19:01 PST (History)
10 users (show)

See Also:


Attachments
Patch (2.52 KB, patch)
2022-02-25 17:19 PST, Simon Fraser (smfr)
thorton: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (5.01 KB, patch)
2022-02-28 10:12 PST, Simon Fraser (smfr)
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (7.65 KB, patch)
2022-02-28 14:41 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2022-02-07 08:49:46 PST
https://css-tricks.com/css-scroll-snap-slide-deck/ describes a slide deck using scroll snap for the slides. In the result <https://codepen.io/5t3ph/full/yLzQeGr/652097fa9ce1150aeb5400637ab91b63>, moving between slides via the keyboard doesn't animate in Safari, but odes in Chrome and Firefox.
Comment 1 Radar WebKit Bug Importer 2022-02-07 08:50:12 PST
<rdar://problem/88574200>
Comment 2 Simon Fraser (smfr) 2022-02-25 17:19:35 PST
Created attachment 453279 [details]
Patch
Comment 3 Simon Fraser (smfr) 2022-02-26 10:43:28 PST
https://trac.webkit.org/changeset/290548/webkit
Comment 4 Simon Fraser (smfr) 2022-02-28 10:07:21 PST
Reverted in https://trac.webkit.org/changeset/290604/webkit
Comment 5 Simon Fraser (smfr) 2022-02-28 10:12:48 PST
Created attachment 453402 [details]
Patch
Comment 6 Simon Fraser (smfr) 2022-02-28 12:10:52 PST
I think the tests are passing for me because the default value for ScrollAnimatorEnabled comes from the NSScrollAnimationEnabled default.
Comment 7 Simon Fraser (smfr) 2022-02-28 12:38:56 PST
Also NSScrollAnimationEnabled is 1 when read in the web process, and 0 when read in the UI process (when there's a stale default left around)
Comment 8 Simon Fraser (smfr) 2022-02-28 14:41:36 PST
Created attachment 453433 [details]
Patch
Comment 9 EWS 2022-02-28 19:01:24 PST
Committed r290625 (247898@main): <https://commits.webkit.org/247898@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453433 [details].