236237 – REGRESSION(r288872): [GTK][WPE] Ubuntu 18.04 build is broken

Bug 236237 - REGRESSION(r288872): [GTK][WPE] Ubuntu 18.04 build is broken

Summary: REGRESSION(r288872): [GTK][WPE] Ubuntu 18.04 build is broken

Status:	RESOLVED WONTFIX

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Diego Pino

URL:
Keywords:

Depends on:
Blocks:

Reported:	2022-02-07 07:41 PST by Diego Pino
Modified:	2022-02-10 16:35 PST (History)
CC List:	15 users (show)

See Also:

Attachments
Patch (6.21 KB, patch) 2022-02-07 08:53 PST, Diego Pino	no flags	Details \| Formatted Diff \| Diff
Patch (15.45 KB, patch) 2022-02-07 23:26 PST, Diego Pino	ews-feeder: commit-queue-	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Diego Pino 2022-02-07 07:41:33 PST

Ubuntu 18.04 build is broken after r288872

https://build.webkit.org/#/builders/71/builds/411

The error is:

FAILED: WebCore/DerivedSources/AccessibilityAtspiInterfaces.h WebCore/DerivedSources/AccessibilityAtspiInterfaces.c 
cd /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/WebKitBuild/Release/Source/WebCore && gdbus-codegen --interface-prefix=org.a11y.atspi --c-namespace=webkit --pragma-once --interface-info-header --output=/home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/WebKitBuild/Release/WebCore/DerivedSources/AccessibilityAtspiInterfaces.h /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Accessible.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Action.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Application.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Cache.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Collection.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Component.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/DeviceEventController.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/DeviceEventListener.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Document.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/EditableText.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Event.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Hyperlink.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Hypertext.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Image.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Registry.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Selection.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Socket.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/TableCell.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Table.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Text.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Value.xml && gdbus-codegen --interface-prefix=org.a11y.atspi --c-namespace=webkit --interface-info-body --output=/home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/WebKitBuild/Release/WebCore/DerivedSources/AccessibilityAtspiInterfaces.c /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Accessible.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Action.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Application.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Cache.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Collection.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Component.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/DeviceEventController.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/DeviceEventListener.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Document.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/EditableText.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Event.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Hyperlink.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Hypertext.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Image.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Registry.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Selection.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Socket.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/TableCell.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Table.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Text.xml /home/buildbot/webkitgtk/nightly/gtk-linux-64-packaging-nigthly-ubuntu1804/build/Source/WebCore/accessibility/atspi/xml/Value.xml
usage: gdbus-codegen [-h] [--xml-files FILE] [--interface-prefix PREFIX]
                     [--c-namespace NAMESPACE] [--c-generate-object-manager]
                     [--c-generate-autocleanup {none,objects,all}]
                     [--generate-docbook OUTFILES] [--pragma-once]
                     [--annotate WHAT KEY VALUE WHAT KEY VALUE WHAT KEY VALUE]
                     [--generate-c-code OUTFILES | --header | --body]
                     [--output FILE | --output-directory OUTDIR]
                     [FILE [FILE ...]]
gdbus-codegen: error: unrecognized arguments: --interface-info-header

It seems the problem is in this block of code that became active after r288872:

https://webkit-search.igalia.com/webkit/source/Source/WebCore/PlatformGTK.cmake#199

The `gdbus-codegen` command featured in Ubuntu 18.04 lacks the arguments `--interface-info-body` and `--interface-info-header`. There's `--body` and `--header` though, which might be used instead for Ubuntu 18.04.

http://manpages.ubuntu.com/manpages/bionic/man1/gdbus-codegen.1.html

Comment 1 Diego Pino 2022-02-07 08:53:45 PST

Created attachment 451112 [details]
Patch

Comment 2 Diego Pino 2022-02-07 23:26:28 PST

Created attachment 451214 [details]
Patch

Comment 3 Diego Pino 2022-02-08 07:40:52 PST

Discussing this bug with Carlos García, we agreed is better that Ubuntu 18.04, and other old systems, build using the flag `--cmakeargs=-DUSE_ATSPI=OFF`.