RESOLVED FIXED 236234
[model] improve sizing on iOS 
https://bugs.webkit.org/show_bug.cgi?id=236234
Summary [model] improve sizing on iOS
Antoine Quint
Reported 2022-02-07 06:55:27 PST
[model] improve sizing on iOS
Attachments
Patch (3.47 KB, patch)
2022-02-07 07:20 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-02-07 06:55:48 PST
<rdar://problem/88569898>
Antoine Quint
Comment 2 2022-02-07 07:20:47 PST
Created attachment 451094 [details] Patch
Dean Jackson
Comment 3 2022-02-07 07:48:29 PST
Comment on attachment 451094 [details] Patch Any way to test this?
Antoine Quint
Comment 4 2022-02-07 08:04:57 PST
(In reply to Dean Jackson from comment #3) > Comment on attachment 451094 [details] > Patch > > Any way to test this? This sets the size in ways that are internal to ARQL, I don't think we can test this.
Darin Adler
Comment 5 2022-02-07 08:49:13 PST
To state something we have learned over the years on the WebKit project: If we want to keep this working we have to figure out some way to regression test. Even if it involves thinking creatively and adding new test hooks of some kind. Otherwise it just breaks some day without anyone noticing.
Antoine Quint
Comment 6 2022-02-07 08:53:29 PST
I'll engage with the right people internally to see how we could test this correctly.
Antoine Quint
Comment 7 2022-02-07 09:42:24 PST
I think we might be able to cook something up with empty model resources and turning on debug colors on ASVInlinePreview instances which should allow us to have predictable renderings to test against.
EWS
Comment 8 2022-02-07 11:43:57 PST
Committed r289235 (246919@main): <https://commits.webkit.org/246919@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451094 [details].
Note You need to log in before you can comment on or make changes to this bug.