Bug 236234 - [model] improve sizing on iOS
Summary: [model] improve sizing on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on: 236233
Blocks:
  Show dependency tree / graph
 
Reported: 2022-02-07 06:55 PST by Antoine Quint
Modified: 2022-02-07 11:44 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.47 KB, patch)
2022-02-07 07:20 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2022-02-07 06:55:27 PST 
[model] improve sizing on iOS
Comment 1 Radar WebKit Bug Importer 2022-02-07 06:55:48 PST 
<rdar://problem/88569898>
Comment 2 Antoine Quint 2022-02-07 07:20:47 PST 
Created attachment 451094 [details]
Patch
Comment 3 Dean Jackson 2022-02-07 07:48:29 PST 
Comment on attachment 451094 [details]
Patch

Any way to test this?
Comment 4 Antoine Quint 2022-02-07 08:04:57 PST 
(In reply to Dean Jackson from comment #3)
> Comment on attachment 451094 [details]
> Patch
> 
> Any way to test this?

This sets the size in ways that are internal to ARQL, I don't think we can test this.
Comment 5 Darin Adler 2022-02-07 08:49:13 PST 
To state something we have learned over the years on the WebKit project: If we want to keep this working we have to figure out some way to regression test. Even if it involves thinking creatively and adding new test hooks of some kind. Otherwise it just breaks some day without anyone noticing.
Comment 6 Antoine Quint 2022-02-07 08:53:29 PST 
I'll engage with the right people internally to see how we could test this correctly.
Comment 7 Antoine Quint 2022-02-07 09:42:24 PST 
I think we might be able to cook something up with empty model resources and turning on debug colors on ASVInlinePreview instances which should allow us to have predictable renderings to test against.
Comment 8 EWS 2022-02-07 11:43:57 PST 
Committed r289235 (246919@main): <https://commits.webkit.org/246919@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451094 [details].