Bug 236220 - Refactor RenderLayer::scrollRectToVisible
Summary: Refactor RenderLayer::scrollRectToVisible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-07 01:17 PST by Martin Robinson
Modified: 2022-07-19 03:00 PDT (History)
25 users (show)

See Also:


Attachments
Patch (87.41 KB, patch)
2022-02-07 07:12 PST, Martin Robinson
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (87.42 KB, patch)
2022-02-07 08:31 PST, Martin Robinson
no flags Details | Formatted Diff | Diff
Patch (87.43 KB, patch)
2022-02-08 01:09 PST, Martin Robinson
no flags Details | Formatted Diff | Diff
Patch (87.42 KB, patch)
2022-02-08 10:51 PST, Martin Robinson
no flags Details | Formatted Diff | Diff
Patch (87.44 KB, patch)
2022-02-09 05:27 PST, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2022-02-07 01:17:29 PST
RenderLayer::scrollRectToVisible has three different paths including one for RenderLayers that scroll, one for top-level FrameViews, and one for child FrameViews. The combined complexity of the three paths makes the method quite large and hard to understand. This bug tracks refactoring the logic so that it's easier to understand.
Comment 1 Martin Robinson 2022-02-07 07:12:35 PST
Created attachment 451093 [details]
Patch
Comment 2 Martin Robinson 2022-02-07 08:31:30 PST
Created attachment 451109 [details]
Patch
Comment 3 Martin Robinson 2022-02-08 01:09:35 PST
Created attachment 451219 [details]
Patch
Comment 4 Martin Robinson 2022-02-08 10:51:44 PST
Created attachment 451275 [details]
Patch
Comment 5 Martin Robinson 2022-02-09 05:27:37 PST
Created attachment 451362 [details]
Patch
Comment 6 Martin Robinson 2022-02-10 06:30:01 PST
Comment on attachment 451362 [details]
Patch

Okay. After fighting with the CI, I think this patch is ready for review. :)
Comment 7 Radar WebKit Bug Importer 2022-02-14 01:18:16 PST
<rdar://problem/88893284>
Comment 8 Martin Robinson 2022-05-27 01:20:21 PDT
Pull request: https://github.com/WebKit/WebKit/pull/1088
Comment 9 EWS 2022-07-19 03:00:25 PDT
Committed 252595@main (ba34b343955e): <https://commits.webkit.org/252595@main>

Reviewed commits have been landed. Closing PR #1088 and removing active labels.