Bug 23619 - ASSERT(!error.isNull()) in DocumentLoader::mainReceivedError() when an SVG image load is cancelled
Summary: ASSERT(!error.isNull()) in DocumentLoader::mainReceivedError() when an SVG im...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-29 03:24 PST by Alexey Proskuryakov
Modified: 2009-01-29 13:55 PST (History)
0 users

See Also:


Attachments
proposed patch (3.67 KB, patch)
2009-01-29 04:02 PST, Alexey Proskuryakov
zimmermann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2009-01-29 03:24:56 PST
I'm seeing a random assertion failure when running layout tests due to a recently added assertion:

void DocumentLoader::mainReceivedError(const ResourceError& error, bool isComplete)
{
    ASSERT(!error.isNull());
...

The problem is that EmptyFrameLoaderClient always creates null errors.
Comment 1 Alexey Proskuryakov 2009-01-29 04:02:36 PST
Created attachment 27145 [details]
proposed patch
Comment 2 Nikolas Zimmermann 2009-01-29 13:55:04 PST
Comment on attachment 27145 [details]
proposed patch

Looks sane, if the ChangeLog gets fixed, r=me.
Comment 3 Alexey Proskuryakov 2009-01-29 13:55:37 PST
Committed revision 40374.