Bug 236187 - [LBSE] Apply position / size to SVG layers
Summary: [LBSE] Apply position / size to SVG layers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords: InRadar
Depends on:
Blocks: 90738 236194
  Show dependency tree / graph
 
Reported: 2022-02-05 16:24 PST by Nikolas Zimmermann
Modified: 2022-02-07 04:52 PST (History)
12 users (show)

See Also:

Attachments
Patch, v1 (4.63 KB, patch)
2022-02-05 16:40 PST, Nikolas Zimmermann 		no flags Details | Formatted Diff | Diff
Patch, v2 (4.73 KB, patch)
2022-02-06 03:00 PST, Nikolas Zimmermann 		rbuis: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2022-02-05 16:24:37 PST 
Prepare RenderLayer/RenderLayerBacking for RenderSVGModelObject support:

Teach RenderLayer::updateLayerPosition() about RenderSVGModelObject derived renderers that create layers.
Grab size and position information from the SVG render tree, just as done for CSS boxes in the render tree.
Comment 1 Nikolas Zimmermann 2022-02-05 16:40:19 PST 
Created attachment 451012 [details]
Patch, v1
Comment 2 Nikolas Zimmermann 2022-02-06 03:00:01 PST 
Revisiting the whole patch series I noticed this is one of the few places still using the renderer().isRenderSVGModelObject( / renderer().isSVGText() / ... accessors directly instead of is<RenderSVGModelObject>(renderer()).

For consistency reasons, I've decided to cleanup this while I'm at it -- that's the diff from patch v1 -> v2.
Comment 3 Nikolas Zimmermann 2022-02-06 03:00:18 PST 
Created attachment 451031 [details]
Patch, v2
Comment 4 Nikolas Zimmermann 2022-02-07 04:51:38 PST 
Committed r289207 (246892@trunk): <https://commits.webkit.org/246892@trunk>
Comment 5 Radar WebKit Bug Importer 2022-02-07 04:52:19 PST 
<rdar://problem/88566767>