Bug 236180 - [WTF] Make Bitmap constexpr friendly
Summary: [WTF] Make Bitmap constexpr friendly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-05 11:23 PST by Yusuke Suzuki
Modified: 2022-02-06 11:25 PST (History)
11 users (show)

See Also:

Attachments
Patch (14.82 KB, patch)
2022-02-05 11:27 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (15.21 KB, patch)
2022-02-05 11:31 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (16.82 KB, patch)
2022-02-06 00:56 PST, Yusuke Suzuki 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2022-02-05 11:23:41 PST 
[WTF] Make Bitmap constexpr friendly
Comment 1 Yusuke Suzuki 2022-02-05 11:27:50 PST 
Created attachment 450992 [details]
Patch
Comment 2 Yusuke Suzuki 2022-02-05 11:31:04 PST 
Created attachment 450993 [details]
Patch
Comment 3 Saam Barati 2022-02-05 13:17:52 PST 
Comment on attachment 450993 [details]
Patch

Lots of red.
Comment 4 Darin Adler 2022-02-05 16:28:27 PST 
Comment on attachment 450993 [details]
Patch

Looks great. I will review after you fix TestWebKitAPI
Comment 5 Yusuke Suzuki 2022-02-06 00:56:13 PST 
Created attachment 451026 [details]
Patch
Comment 6 Darin Adler 2022-02-06 10:45:19 PST 
Comment on attachment 451026 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451026&action=review

> Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:547
> +    static constexpr Bitmap<256> doNotUnescapeWhenDecodingURI = makeCharacterBitmap(

I would have written auto in these places instead of repeating the type.
Comment 7 Yusuke Suzuki 2022-02-06 11:15:43 PST 
Comment on attachment 451026 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451026&action=review

>> Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:547
>> +    static constexpr Bitmap<256> doNotUnescapeWhenDecodingURI = makeCharacterBitmap(
> 
> I would have written auto in these places instead of repeating the type.

Changed.
Comment 8 Yusuke Suzuki 2022-02-06 11:17:36 PST 
Committed r289172 (246868@trunk): <https://commits.webkit.org/246868@trunk>
Comment 9 Radar WebKit Bug Importer 2022-02-06 11:18:17 PST 
<rdar://problem/88546704>
Comment 10 Yusuke Suzuki 2022-02-06 11:25:45 PST 
Committed r289173 (246869@trunk): <https://commits.webkit.org/246869@trunk>