Bug 23618 – Templated worker tasks should be more error proof to use

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[David Levin]

Right now, there is a fair amount of knowing which parameters need to be copied and doing it by hand but it would be nice if the generic worker tasks just handled this for callers.

[David Levin]

Created attachment 27144 [details]
Part 1: Add useful templates to TypeTraits.h

I checked that these compile with vs2005 (and the compile asserts should have caught if they were not functioning).

[Alexey Proskuryakov]

Comment on attachment 27144 [details]
Part 1: Add useful templates to TypeTraits.h

+        * wtf/TypeTraits.h:
+        (WTF::):

Mistakes made by prepare-ChangeLog such as this one should be corrected manually. In this case, is is probably best to just remove this line - but generally, we prefer comments to be per-function or at least per-file.

+    // The following are providing in this file:

This doesn't look like correct English grammar to me.

+    template<typename T> struct IsConvertibleToInteger {
+    private:
+        typedef char YesType;

If it were a class, you wouldn't need private: at the start.

This is good to land as is, maybe with a small correction to grammar. r=me

[David Levin]

Created attachment 27162 [details]
Land this which is the R+ review plus a spelling correction (and minor changelog change).

[David Levin]

Created attachment 27169 [details]
Part 2: Add the copying mechanisms and extra classes for GenericWorkerTasks.

[Alexey Proskuryakov]

Comment on attachment 27144 [details]
Part 1: Add useful templates to TypeTraits.h

Committed revision 40400.

[David Levin]

Created attachment 27176 [details]
Part 2: Add the copying mechanisms and extra classes for GenericWorkerTasks.

Removed the RemoveConstVolatile usage for now.

[Alexey Proskuryakov]

Comment on attachment 27176 [details]
Part 2: Add the copying mechanisms and extra classes for GenericWorkerTasks.

r=me

[David Levin]

Created attachment 27192 [details]
Part 1.1:  Fix chromium build.

Part 1 has been checked in and now breaks the chromium build (due to it having an additional warning turned on).  This patch fixes the chromium build.

[Dimitri Glazkov (Google)]

Part 1.1. committed in http://trac.webkit.org/changeset/40418

[David Levin]

Comment on attachment 27192 [details]
Part 1.1:  Fix chromium build.

committed in http://trac.webkit.org/changeset/40418

[Alexey Proskuryakov]

Part 2 committed revision 40525.