Bug 236177 - [LFC][IFC] Add initial ideographic baseline support
Summary: [LFC][IFC] Add initial ideographic baseline support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-05 06:27 PST by zalan
Modified: 2022-02-06 14:30 PST (History)
5 users (show)

See Also:

Attachments
Patch (9.92 KB, patch)
2022-02-05 06:35 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (6.92 KB, patch)
2022-02-05 13:52 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-02-05 06:27:35 PST 
not enabled yet.
Comment 1 zalan 2022-02-05 06:35:21 PST 
Created attachment 450983 [details]
Patch
Comment 2 Antti Koivisto 2022-02-05 07:38:08 PST 
Comment on attachment 450983 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450983&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:207
> +    InlineLayoutUnit ascent = fontMetrics.ascent(useIdeographicBaseline ? IdeographicBaseline : AlphabeticBaseline);
> +    InlineLayoutUnit descent = fontMetrics.descent(useIdeographicBaseline ? IdeographicBaseline : AlphabeticBaseline);

Maybe this code could just use the existing FontBaseline enum everywhere (though it should be enum class)?

> Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.h:52
> +    enum class UseIdeographicBaseline : uint8_t { No, Yes };

Replacing this too.
Comment 3 zalan 2022-02-05 07:57:52 PST 
good point
Comment 4 zalan 2022-02-05 13:52:26 PST 
Created attachment 451000 [details]
Patch
Comment 5 EWS 2022-02-06 14:29:16 PST 
Committed r289183 (246875@main): <https://commits.webkit.org/246875@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451000 [details].
Comment 6 Radar WebKit Bug Importer 2022-02-06 14:30:16 PST 
<rdar://problem/88548584>