RESOLVED FIXED 236177
[LFC][IFC] Add initial ideographic baseline support 
https://bugs.webkit.org/show_bug.cgi?id=236177
Summary [LFC][IFC] Add initial ideographic baseline support
zalan
Reported 2022-02-05 06:27:35 PST
not enabled yet.
Attachments
Patch (9.92 KB, patch)
2022-02-05 06:35 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (6.92 KB, patch)
2022-02-05 13:52 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2022-02-05 06:35:21 PST
Created attachment 450983 [details] Patch
Antti Koivisto
Comment 2 2022-02-05 07:38:08 PST
Comment on attachment 450983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450983&action=review > Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:207 > + InlineLayoutUnit ascent = fontMetrics.ascent(useIdeographicBaseline ? IdeographicBaseline : AlphabeticBaseline); > + InlineLayoutUnit descent = fontMetrics.descent(useIdeographicBaseline ? IdeographicBaseline : AlphabeticBaseline); Maybe this code could just use the existing FontBaseline enum everywhere (though it should be enum class)? > Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.h:52 > + enum class UseIdeographicBaseline : uint8_t { No, Yes }; Replacing this too.
zalan
Comment 3 2022-02-05 07:57:52 PST
good point
zalan
Comment 4 2022-02-05 13:52:26 PST
Created attachment 451000 [details] Patch
EWS
Comment 5 2022-02-06 14:29:16 PST
Committed r289183 (246875@main): <https://commits.webkit.org/246875@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451000 [details].
Radar WebKit Bug Importer
Comment 6 2022-02-06 14:30:16 PST
<rdar://problem/88548584>
Note You need to log in before you can comment on or make changes to this bug.