Bug 236170 - Tidy up some ImageBuffer-related classes
Summary: Tidy up some ImageBuffer-related classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-04 20:49 PST by Simon Fraser (smfr)
Modified: 2022-02-07 14:29 PST (History)
12 users (show)

See Also:

Attachments
Patch (15.40 KB, patch)
2022-02-04 20:51 PST, Simon Fraser (smfr) 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (18.85 KB, patch)
2022-02-04 21:57 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (19.73 KB, patch)
2022-02-05 11:08 PST, Simon Fraser (smfr) 		darin: review+
Details | Formatted Diff | Diff
Patch (22.12 KB, patch)
2022-02-07 12:08 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2022-02-04 20:49:30 PST 
Tidy up some ImageBuffer-related classes
Comment 1 Simon Fraser (smfr) 2022-02-04 20:51:10 PST 
Created attachment 450970 [details]
Patch
Comment 2 Simon Fraser (smfr) 2022-02-04 21:57:22 PST 
Created attachment 450973 [details]
Patch
Comment 3 Simon Fraser (smfr) 2022-02-05 11:08:01 PST 
Created attachment 450991 [details]
Patch
Comment 4 Darin Adler 2022-02-06 15:21:32 PST 
Comment on attachment 450991 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450991&action=review

> Source/WebCore/platform/graphics/cg/ImageBufferCGBitmapBackend.h:49
> +    GraphicsContext& context() const final;

Could consider also making these private if they are always called polymorphically, on the ImageBufferCGBackend base class.
Comment 5 Simon Fraser (smfr) 2022-02-07 12:08:16 PST 
Created attachment 451135 [details]
Patch
Comment 6 Simon Fraser (smfr) 2022-02-07 14:28:10 PST 
https://trac.webkit.org/changeset/289240/webkit
Comment 7 Radar WebKit Bug Importer 2022-02-07 14:29:43 PST 
<rdar://problem/88594557>