WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
236169
Notification refactoring
https://bugs.webkit.org/show_bug.cgi?id=236169
Summary
Notification refactoring
Brady Eidson
Reported
2022-02-04 18:32:50 PST
Notification refactoring All in support of upcoming showNotification() work. Splitting some "no behavior change" bits from a mega patch out here, including: - Make Notification objects reliant on ScriptExecutionContext, and not Documents - Give them more direct access to a NotificationClient instead of having to go through a Page's NotificationController - Give ServiceWorkerGlobalScope objects a SessionID for future use
Attachments
EWS v1
(33.91 KB, patch)
2022-02-04 18:41 PST
,
Brady Eidson
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
EWS v2
(34.14 KB, patch)
2022-02-04 19:11 PST
,
Brady Eidson
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
EWS v3
(34.15 KB, patch)
2022-02-04 19:23 PST
,
Brady Eidson
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
EWS v4
(33.95 KB, patch)
2022-02-04 19:41 PST
,
Brady Eidson
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
EWS v5
(34.02 KB, patch)
2022-02-04 19:55 PST
,
Brady Eidson
achristensen
: review+
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
EWS v6
(34.12 KB, patch)
2022-02-04 20:30 PST
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
EWS v7
(34.58 KB, patch)
2022-02-04 21:25 PST
,
Brady Eidson
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(6)
View All
Add attachment
proposed patch, testcase, etc.
Brady Eidson
Comment 1
2022-02-04 18:41:36 PST
Created
attachment 450961
[details]
EWS v1
Brady Eidson
Comment 2
2022-02-04 19:11:18 PST
Created
attachment 450964
[details]
EWS v2
Brady Eidson
Comment 3
2022-02-04 19:23:03 PST
Created
attachment 450965
[details]
EWS v3
Brady Eidson
Comment 4
2022-02-04 19:41:42 PST
Created
attachment 450966
[details]
EWS v4
Brady Eidson
Comment 5
2022-02-04 19:55:47 PST
Created
attachment 450967
[details]
EWS v5
Brady Eidson
Comment 6
2022-02-04 20:30:23 PST
Created
attachment 450969
[details]
EWS v6
Brady Eidson
Comment 7
2022-02-04 21:25:45 PST
Created
attachment 450972
[details]
EWS v7
EWS
Comment 8
2022-02-05 00:11:47 PST
Committed
r289153
(
246849@main
): <
https://commits.webkit.org/246849@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 450972
[details]
.
Radar WebKit Bug Importer
Comment 9
2022-02-05 00:12:19 PST
<
rdar://problem/88522349
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug