Bug 236166 - AX: Move node-dependent role computation to AccessibilityNodeObject from AccessibilityRenderObject
Summary: AX: Move node-dependent role computation to AccessibilityNodeObject from Acce...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-04 16:27 PST by Tyler Wilcock
Modified: 2022-02-07 16:23 PST (History)
10 users (show)

See Also:


Attachments
Patch (45.21 KB, patch)
2022-02-04 16:38 PST, Tyler Wilcock
no flags Details | Formatted Diff | Diff
Patch (63.71 KB, patch)
2022-02-05 08:54 PST, Tyler Wilcock
no flags Details | Formatted Diff | Diff
Patch (63.70 KB, patch)
2022-02-07 10:47 PST, Tyler Wilcock
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2022-02-04 16:27:55 PST
This will make AX objects that typically have renderers but sometimes don't (e.g. objects with `hidden` + `aria-hidden="false"`, eventually objects with `display: contents`) more accessible.
Comment 1 Radar WebKit Bug Importer 2022-02-04 16:28:11 PST
<rdar://problem/88513740>
Comment 2 Tyler Wilcock 2022-02-04 16:38:01 PST
Created attachment 450948 [details]
Patch
Comment 3 Tyler Wilcock 2022-02-05 08:54:58 PST
Created attachment 450988 [details]
Patch
Comment 4 chris fleizach 2022-02-07 09:21:36 PST
Comment on attachment 450988 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450988&action=review

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:256
> +        HTMLSelectElement& selectElement = downcast<HTMLSelectElement>(*node());

can probably use auto& here
Comment 5 Tyler Wilcock 2022-02-07 10:47:59 PST
Created attachment 451124 [details]
Patch
Comment 6 EWS 2022-02-07 16:23:33 PST
Committed r289248 (246932@main): <https://commits.webkit.org/246932@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451124 [details].