Bug 236164 - [libpas] allocation failure crash should be PAS_NEVER_INLINE
Summary: [libpas] allocation failure crash should be PAS_NEVER_INLINE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-04 15:55 PST by Yusuke Suzuki
Modified: 2022-02-04 16:52 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.67 KB, patch)
2022-02-04 15:56 PST, Yusuke Suzuki
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (3.14 KB, patch)
2022-02-04 16:17 PST, Yusuke Suzuki
saam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2022-02-04 15:55:12 PST
[libpas] allocation failure crash should be NEVER_INLINED
Comment 1 Yusuke Suzuki 2022-02-04 15:56:23 PST
Created attachment 450946 [details]
Patch
Comment 2 Yusuke Suzuki 2022-02-04 15:57:18 PST
Comment on attachment 450946 [details]
Patch

Oops, I'll a bit fix it.
Comment 3 Yusuke Suzuki 2022-02-04 16:17:24 PST
Created attachment 450947 [details]
Patch
Comment 4 Saam Barati 2022-02-04 16:19:59 PST
Comment on attachment 450947 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450947&action=review

> Source/bmalloc/libpas/src/libpas/pas_utils.c:60
> +    pas_panic("allocation did fail because of out-of-memory\n");

do we want to make sure this call gets inlined?
Comment 5 Yusuke Suzuki 2022-02-04 16:21:53 PST
Comment on attachment 450947 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450947&action=review

>> Source/bmalloc/libpas/src/libpas/pas_utils.c:60
>> +    pas_panic("allocation did fail because of out-of-memory\n");
> 
> do we want to make sure this call gets inlined?

Discussed with Saam. I'll change it to __builtin_trap to make pas_panic_on_out_of_memory_error top signature.
Comment 6 Yusuke Suzuki 2022-02-04 16:50:17 PST
OK we ensured it is built, landing.
Comment 7 Yusuke Suzuki 2022-02-04 16:51:59 PST
Committed r289144 (246840@trunk): <https://commits.webkit.org/246840@trunk>
Comment 8 Radar WebKit Bug Importer 2022-02-04 16:52:16 PST
<rdar://problem/88514835>