RESOLVED FIXED236151
[WebAuthn] Use AuthenticationServicesAgent for WebAuthn calls on iOS 
https://bugs.webkit.org/show_bug.cgi?id=236151
Summary [WebAuthn] Use AuthenticationServicesAgent for WebAuthn calls on iOS
pascoe@apple.com
Reported 2022-02-04 12:33:30 PST
^
Attachments
Patch (7.96 KB, patch)
2022-02-04 12:37 PST, pascoe@apple.com 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.96 KB, patch)
2022-02-08 13:18 PST, pascoe@apple.com 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
pascoe@apple.com
Comment 1 2022-02-04 12:33:41 PST
rdar://87908259
pascoe@apple.com
Comment 2 2022-02-04 12:37:31 PST
Created attachment 450930 [details] Patch
Brent Fulgham
Comment 3 2022-02-08 10:53:06 PST
Comment on attachment 450930 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450930&action=review r=me > Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:313 > + [proxy.get() performAuthorizationRequestsForContext:requestContext.get() withCompletionHandler:makeBlockPtr([handler = WTFMove(handler), proxy = WTFMove(proxy)](id <ASCCredentialProtocol> credential, NSError *error) mutable { Nit: I don't think you need to 'get()' on proxy when calling a method like this (though you *do* need to call 'get()' when you want to pass a pointer.
pascoe@apple.com
Comment 4 2022-02-08 13:18:24 PST
Created attachment 451300 [details] Patch for landing
EWS
Comment 5 2022-02-08 14:45:09 PST
Committed r289436 (246989@main): <https://commits.webkit.org/246989@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451300 [details].
Note You need to log in before you can comment on or make changes to this bug.