Bug 236151 - [WebAuthn] Use AuthenticationServicesAgent for WebAuthn calls on iOS
Summary: [WebAuthn] Use AuthenticationServicesAgent for WebAuthn calls on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: pascoe@apple.com
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-04 12:33 PST by pascoe@apple.com
Modified: 2022-02-08 14:45 PST (History)
4 users (show)

See Also:

Attachments
Patch (7.96 KB, patch)
2022-02-04 12:37 PST, pascoe@apple.com 		no flags Details | Formatted Diff | Diff
Patch for landing (7.96 KB, patch)
2022-02-08 13:18 PST, pascoe@apple.com 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description pascoe@apple.com 2022-02-04 12:33:30 PST 
^
Comment 1 pascoe@apple.com 2022-02-04 12:33:41 PST 
rdar://87908259
Comment 2 pascoe@apple.com 2022-02-04 12:37:31 PST 
Created attachment 450930 [details]
Patch
Comment 3 Brent Fulgham 2022-02-08 10:53:06 PST 
Comment on attachment 450930 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450930&action=review

r=me

> Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:313
> +    [proxy.get() performAuthorizationRequestsForContext:requestContext.get() withCompletionHandler:makeBlockPtr([handler = WTFMove(handler), proxy = WTFMove(proxy)](id <ASCCredentialProtocol> credential, NSError *error) mutable {

Nit: I don't think you need to 'get()' on proxy when calling a method like this (though you *do* need to call 'get()' when you want to pass a pointer.
Comment 4 pascoe@apple.com 2022-02-08 13:18:24 PST 
Created attachment 451300 [details]
Patch for landing
Comment 5 EWS 2022-02-08 14:45:09 PST 
Committed r289436 (246989@main): <https://commits.webkit.org/246989@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451300 [details].