Bug 23615 - Try to make layout test timeout-release-on-close.html reliable
Summary: Try to make layout test timeout-release-on-close.html reliable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dmitry Titov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-29 00:53 PST by Dmitry Titov
Modified: 2009-01-30 09:07 PST (History)
1 user (show)

See Also:


Attachments
Proposed patch (4.58 KB, patch)
2009-01-29 01:07 PST, Dmitry Titov
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Titov 2009-01-29 00:53:43 PST
This test sometimes fails on buildbots. I could not reproduce the failure, but looking at other similar tests (Layout/fast/dom/gc-10.html) I think the following can improve it:

- Use threshold when comparing the number of objects to account for objects that can be allocated by the running script itself.
- Increase the number of allocated objects that should be released to make test less sensitive to other allocations.
- Add debug output in case test fails to investigate further.

Patch is coming.
Comment 1 Dmitry Titov 2009-01-29 01:07:51 PST
Created attachment 27140 [details]
Proposed patch
Comment 2 Alexey Proskuryakov 2009-01-29 01:21:20 PST
Comment on attachment 27140 [details]
Proposed patch

r=me
Comment 3 Darin Fisher (:fishd, Google) 2009-01-30 09:07:19 PST
http://trac.webkit.org/changeset/40405