Bug 236136 - [Flatpak SDK] Update to FDO 21.08.10 and GStreamer 1.20 releases
Summary: [Flatpak SDK] Update to FDO 21.08.10 and GStreamer 1.20 releases
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-04 06:25 PST by Philippe Normand
Modified: 2022-03-14 21:07 PDT (History)
17 users (show)

See Also:

Attachments
[fast-cq] Patch (62.39 KB, patch)
2022-02-04 09:44 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2022-02-04 06:25:44 PST 
.
Comment 1 Philippe Normand 2022-02-04 09:44:08 PST 
Created attachment 450909 [details]
[fast-cq] Patch
Comment 2 EWS 2022-02-05 01:26:21 PST 
Committed r289154 (246850@main): <https://commits.webkit.org/246850@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450909 [details].
Comment 3 Radar WebKit Bug Importer 2022-02-05 01:27:17 PST 
<rdar://problem/88523100>
Comment 4 Olivier Blin 2022-03-09 02:46:16 PST 
Comment on attachment 450909 [details]
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450909&action=review

> Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp:370
> -        if (factory && !g_strcmp0(GST_OBJECT_NAME(GST_OBJECT(factory.get())), "vp8dec")) {
> -            GST_INFO("Our best GStreamer VP8 decoder is vp8dec, better use the one from LibWebRTC");
> -
> -            return std::unique_ptr<webrtc::VideoDecoder>(new webrtc::LibvpxVp8Decoder());
> +        if (!factory) {

The check has been reversed, it should be "if (factory)" since the factory object is accessed in the code block.