Bug 236132 - LibWebRTCCodecs SharedVideoFrameWriters can deadlock in case of GPUProcess crash
Summary: LibWebRTCCodecs SharedVideoFrameWriters can deadlock in case of GPUProcess crash
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-04 02:14 PST by youenn fablet
Modified: 2022-02-08 09:17 PST (History)
8 users (show)

See Also:

Attachments
Patch (21.13 KB, patch)
2022-02-04 03:52 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (21.07 KB, patch)
2022-02-08 03:14 PST, youenn fablet 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (21.30 KB, patch)
2022-02-08 03:49 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (22.06 KB, patch)
2022-02-08 04:40 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2022-02-04 02:14:36 PST 
LibWebRTCCodecs SharedVideoFrameWriters can deadlock in case of GPUProcess crash
Comment 1 youenn fablet 2022-02-04 03:52:04 PST 
Created attachment 450883 [details]
Patch
Comment 2 Eric Carlson 2022-02-04 09:16:32 PST 
Comment on attachment 450883 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450883&action=review

> Source/WebKit/ChangeLog:10
> +        To prevent this, whenever we detect a GPUProcess connection, we disable SharedVideoFrameWriters, which has the effect of

Do you mean whenever we detect a GPUProcess *crash*?

> Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.cpp:45
> +    fprintf(stderr, "SharedVideoFrameWriter::wait\n");

Oops!

> LayoutTests/webrtc/vp8-then-h264-gpu-process-crash.html:91
> +}, "Frames should be coming event after gpu process crash");

a/event/even/
Comment 3 youenn fablet 2022-02-08 03:14:36 PST 
Created attachment 451231 [details]
Patch for landing
Comment 4 youenn fablet 2022-02-08 03:49:05 PST 
Created attachment 451232 [details]
Patch for landing
Comment 5 EWS 2022-02-08 04:27:56 PST 
Patch 451231 does not build
Comment 6 youenn fablet 2022-02-08 04:40:01 PST 
Created attachment 451236 [details]
Patch for landing
Comment 7 EWS 2022-02-08 09:16:07 PST 
Committed r289381 (246969@main): <https://commits.webkit.org/246969@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451236 [details].
Comment 8 Radar WebKit Bug Importer 2022-02-08 09:17:17 PST 
<rdar://problem/88633294>