Bug 236132 – LibWebRTCCodecs SharedVideoFrameWriters can deadlock in case of GPUProcess crash

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

LibWebRTCCodecs SharedVideoFrameWriters can deadlock in case of GPUProcess crash

[youenn fablet]

Created attachment 450883 [details]
Patch

[Eric Carlson]

Comment on attachment 450883 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450883&action=review

> Source/WebKit/ChangeLog:10
> +        To prevent this, whenever we detect a GPUProcess connection, we disable SharedVideoFrameWriters, which has the effect of

Do you mean whenever we detect a GPUProcess *crash*?

> Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.cpp:45
> +    fprintf(stderr, "SharedVideoFrameWriter::wait\n");

Oops!

> LayoutTests/webrtc/vp8-then-h264-gpu-process-crash.html:91
> +}, "Frames should be coming event after gpu process crash");

a/event/even/

[youenn fablet]

Created attachment 451231 [details]
Patch for landing

[youenn fablet]

Created attachment 451232 [details]
Patch for landing

[EWS]

Patch 451231 does not build

[youenn fablet]

Created attachment 451236 [details]
Patch for landing

[EWS]

Committed r289381 (246969@main): <https://commits.webkit.org/246969@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451236 [details].

[Radar WebKit Bug Importer]

<rdar://problem/88633294>