Bug 236129 - Fix for non-unified builds after r286821 (245056@main)
Summary: Fix for non-unified builds after r286821 (245056@main)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pablo Saavedra
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-04 00:07 PST by Pablo Saavedra
Modified: 2022-02-04 00:17 PST (History)
1 user (show)

See Also:

Attachments
patch (1.26 KB, patch)
2022-02-04 00:09 PST, Pablo Saavedra 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pablo Saavedra 2022-02-04 00:07:02 PST 
SSIA


Error:

In file included from /home/bot/workspace/sources/wpewebkit/Source/WebCore/workers/shared/SharedWorkerScriptLoader.cpp:27:
/home/bot/workspace/sources/wpewebkit/Source/WebCore/workers/shared/SharedWorkerScriptLoader.h:51:5: error: 'SharedWorkerScriptLoaderIdentifier' does not name a type; did you mean 'SharedWorkerScriptLoader'?
   51 |     SharedWorkerScriptLoaderIdentifier identifier() const { return m_identifier; }
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |     SharedWorkerScriptLoader
/home/bot/workspace/sources/wpewebkit/Source/WebCore/workers/shared/SharedWorkerScriptLoader.h:60:11: error: 'SharedWorkerScriptLoaderIdentifier' does not name a type; did you mean 'SharedWorkerScriptLoader'?
   60 |     const SharedWorkerScriptLoaderIdentifier m_identifier;
      |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |           SharedWorkerScriptLoader
/home/bot/workspace/sources/wpewebkit/Source/WebCore/workers/shared/SharedWorkerScriptLoader.cpp: In constructor 'WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader(const WTF::URL&, WebCore::SharedWorker&, WebCore::TransferredMessagePort&&, WebCore::WorkerOptions&&)':
/home/bot/workspace/sources/wpewebkit/Source/WebCore/workers/shared/SharedWorkerScriptLoader.cpp:39:7: error: class 'WebCore::SharedWorkerScriptLoader' does not have any field named 'm_identifier'
   39 |     : m_identifier(SharedWorkerScriptLoaderIdentifier::generate())
      |       ^~~~~~~~~~~~
Comment 1 Pablo Saavedra 2022-02-04 00:09:42 PST 
Created attachment 450879 [details]
patch
Comment 2 EWS 2022-02-04 00:10:23 PST 
psaavedra@igalia.com does not have reviewer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json.

Rejecting attachment 450879 [details] from commit queue.
Comment 3 Pablo Saavedra 2022-02-04 00:14:18 PST 
Committed r289107 (246804@trunk): <https://commits.webkit.org/246804@trunk>
Comment 4 Radar WebKit Bug Importer 2022-02-04 00:15:18 PST 
<rdar://problem/88477288>
Comment 5 Pablo Saavedra 2022-02-04 00:17:15 PST 
Just for reference, landed as unreviewed patch for the sake of simplicity .