WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
236112
Add pen type for HitTestRequest.
https://bugs.webkit.org/show_bug.cgi?id=236112
Summary
Add pen type for HitTestRequest.
Megan Gardner
Reported
2022-02-03 17:53:54 PST
Add pen type for HitTestRequest.
Attachments
Patch
(2.22 KB, patch)
2022-02-03 17:54 PST
,
Megan Gardner
no flags
Details
Formatted Diff
Diff
Patch
(2.22 KB, patch)
2022-02-03 17:57 PST
,
Megan Gardner
no flags
Details
Formatted Diff
Diff
Patch for landing
(2.22 KB, patch)
2022-02-03 18:33 PST
,
Megan Gardner
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Megan Gardner
Comment 1
2022-02-03 17:54:46 PST
Created
attachment 450842
[details]
Patch
Tim Horton
Comment 2
2022-02-03 17:55:14 PST
Comment on
attachment 450842
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=450842&action=review
> Source/WebCore/rendering/HitTestRequest.h:52 > + PenEvent = 1 << 15,
Not sure why you're re-using a bit.
Tim Horton
Comment 3
2022-02-03 17:56:27 PST
Comment on
attachment 450842
[details]
Patch Also, not sure this should be landed separate from code that propagates it from the event, since as it stands this is untestable and zero-impact.
Megan Gardner
Comment 4
2022-02-03 17:57:17 PST
Created
attachment 450843
[details]
Patch
Megan Gardner
Comment 5
2022-02-03 18:33:16 PST
Created
attachment 450849
[details]
Patch for landing
EWS
Comment 6
2022-02-03 19:15:04 PST
Committed
r289102
(
246799@main
): <
https://commits.webkit.org/246799@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 450849
[details]
.
Radar WebKit Bug Importer
Comment 7
2022-02-03 19:16:18 PST
<
rdar://problem/88469338
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug