Bug 236112 - Add pen type for HitTestRequest.
Summary: Add pen type for HitTestRequest.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-03 17:53 PST by Megan Gardner
Modified: 2022-02-03 19:16 PST (History)
8 users (show)

See Also:


Attachments
Patch (2.22 KB, patch)
2022-02-03 17:54 PST, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch (2.22 KB, patch)
2022-02-03 17:57 PST, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch for landing (2.22 KB, patch)
2022-02-03 18:33 PST, Megan Gardner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2022-02-03 17:53:54 PST
Add pen type for HitTestRequest.
Comment 1 Megan Gardner 2022-02-03 17:54:46 PST
Created attachment 450842 [details]
Patch
Comment 2 Tim Horton 2022-02-03 17:55:14 PST
Comment on attachment 450842 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450842&action=review

> Source/WebCore/rendering/HitTestRequest.h:52
> +        PenEvent = 1 << 15,

Not sure why you're re-using a bit.
Comment 3 Tim Horton 2022-02-03 17:56:27 PST
Comment on attachment 450842 [details]
Patch

Also, not sure this should be landed separate from code that propagates it from the event, since as it stands this is untestable and zero-impact.
Comment 4 Megan Gardner 2022-02-03 17:57:17 PST
Created attachment 450843 [details]
Patch
Comment 5 Megan Gardner 2022-02-03 18:33:16 PST
Created attachment 450849 [details]
Patch for landing
Comment 6 EWS 2022-02-03 19:15:04 PST
Committed r289102 (246799@main): <https://commits.webkit.org/246799@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450849 [details].
Comment 7 Radar WebKit Bug Importer 2022-02-03 19:16:18 PST
<rdar://problem/88469338>