Bug 236089 - Rename ServiceWorkerInitializationData / ServiceWorkerInformation so they can be reused by shared workers
Summary: Rename ServiceWorkerInitializationData / ServiceWorkerInformation so they can...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 235958
  Show dependency treegraph
 
Reported: 2022-02-03 09:47 PST by Chris Dumez
Modified: 2022-02-03 11:47 PST (History)
6 users (show)

See Also:


Attachments
Patch (28.45 KB, patch)
2022-02-03 09:55 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-02-03 09:47:57 PST
Rename ServiceWorkerInitializationData / ServiceWorkerInformation so they can be reused by shared workers.
Comment 1 Chris Dumez 2022-02-03 09:55:45 PST
Created attachment 450787 [details]
Patch
Comment 2 Alex Christensen 2022-02-03 10:56:58 PST
Comment on attachment 450787 [details]
Patch

Is "RemoteWorker" used elsewhere?
I might have called this ServiceOrSharedWorkerInformation
Comment 3 Chris Dumez 2022-02-03 11:02:08 PST
(In reply to Alex Christensen from comment #2)
> Comment on attachment 450787 [details]
> Patch
> 
> Is "RemoteWorker" used elsewhere?
> I might have called this ServiceOrSharedWorkerInformation

Yes, I have used remote worker in a few patches already. The naming was suggested by Youenn during an earlier review.
Comment 4 Darin Adler 2022-02-03 11:34:31 PST
I am really happy to have a term of art instead of "x or y" every time!
Comment 5 EWS 2022-02-03 11:46:06 PST
Committed r289063 (246770@main): <https://commits.webkit.org/246770@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450787 [details].
Comment 6 Radar WebKit Bug Importer 2022-02-03 11:47:18 PST
<rdar://problem/88447663>