Bug 236080 - [Web Animations] Starting a transform animation with a 1ms delay doesn't run it accelerated
Summary: [Web Animations] Starting a transform animation with a 1ms delay doesn't run ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-03 06:25 PST by Antoine Quint
Modified: 2022-02-07 05:58 PST (History)
11 users (show)

See Also:

Attachments
Testcase (353 bytes, text/html)
2022-02-03 06:25 PST, Antoine Quint 		no flags Details
Patch (12.48 KB, patch)
2022-02-04 04:03 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (15.90 KB, patch)
2022-02-05 08:09 PST, Antoine Quint 		dino: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (19.83 KB, patch)
2022-02-07 02:20 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2022-02-03 06:25:37 PST 
Created attachment 450769 [details]
Testcase

The attached example runs a simple "transform" animation with a 1ms delay and we fail to run the animation accelerated. Indeed, by the time we call startAnimation() the renderer is not composited and we bail, never to retry again. We must have some incorrect logic to indicate than the element has a pending accelerated animation and should be composited.
Comment 1 Radar WebKit Bug Importer 2022-02-03 06:27:10 PST 
<rdar://problem/88432373>
Comment 2 Antoine Quint 2022-02-04 04:03:21 PST 
Created attachment 450884 [details]
Patch
Comment 3 Dean Jackson 2022-02-04 06:13:06 PST 
Comment on attachment 450884 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450884&action=review

> Source/WebCore/ChangeLog:22
> +        conditon to do so since its renderer is already composited.

typo: condition
Comment 4 Antoine Quint 2022-02-05 08:09:28 PST 
Created attachment 450984 [details]
Patch
Comment 5 Antoine Quint 2022-02-07 02:20:22 PST 
Created attachment 451071 [details]
Patch for landing
Comment 6 EWS 2022-02-07 05:58:47 PST 
Committed r289211 (246896@main): <https://commits.webkit.org/246896@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451071 [details].