Bug 236064 - CallLinkInfo::emitFastPathImpl() should avoid external scratch register use on RISCV64
Summary: CallLinkInfo::emitFastPathImpl() should avoid external scratch register use o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks: 237775
  Show dependency tree / graph
 
Reported: 2022-02-03 00:48 PST by Zan Dobersek
Modified: 2022-03-11 05:33 PST (History)
11 users (show)

See Also:

Attachments
Patch (4.74 KB, patch)
2022-02-03 00:49 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (4.63 KB, patch)
2022-02-09 12:31 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2022-02-03 00:48:06 PST 
CallLinkInfo::emitFastPathImpl() should avoid external scratch register use on RISCV64
Comment 1 Zan Dobersek 2022-02-03 00:49:04 PST 
Created attachment 450743 [details]
Patch
Comment 2 Geza Lore 2022-02-09 09:10:51 PST 
This might be related: https://bugs.webkit.org/show_bug.cgi?id=232373
Comment 3 Yusuke Suzuki 2022-02-09 09:14:17 PST 
Comment on attachment 450743 [details]
Patch

r- since EWS are red.
Comment 4 Zan Dobersek 2022-02-09 12:31:16 PST 
Created attachment 451426 [details]
Patch

Trivial problem for the non-RISCV64 codepath, now fixed.
Comment 5 Radar WebKit Bug Importer 2022-02-10 00:49:18 PST 
<rdar://problem/88741477>
Comment 6 Zan Dobersek 2022-02-10 01:15:29 PST 
Comment on attachment 451426 [details]
Patch

Unrelated test failure on the ios-wk2 EWS.
Comment 7 EWS 2022-02-14 10:40:34 PST 
Committed r289740 (247225@main): <https://commits.webkit.org/247225@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451426 [details].