Bug 236044 - [macOS] Avoid CF preference calls before entering the sandbox
Summary: [macOS] Avoid CF preference calls before entering the sandbox
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-02 15:48 PST by Per Arne Vollan
Modified: 2022-02-07 09:35 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.88 KB, patch)
2022-02-03 08:12 PST, Per Arne Vollan 		bfulgham: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (5.42 KB, patch)
2022-02-04 08:22 PST, Per Arne Vollan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (5.45 KB, patch)
2022-02-04 09:58 PST, Per Arne Vollan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (5.70 KB, patch)
2022-02-07 08:18 PST, Per Arne Vollan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2022-02-02 15:48:59 PST 
Since CF preferences are doing sandbox checks, we should avoid making CF preference calls before entering the sandbox.
Comment 1 Radar WebKit Bug Importer 2022-02-02 15:49:48 PST 
<rdar://problem/88405607>
Comment 2 Per Arne Vollan 2022-02-03 08:12:52 PST 
Created attachment 450772 [details]
Patch
Comment 3 Brent Fulgham 2022-02-03 08:59:24 PST 
Comment on attachment 450772 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450772&action=review

Nice! r=me

> Source/WebCore/platform/cocoa/SystemVersion.mm:2
> + * Copyright (C) 2012, 2022 Apple Inc. All rights reserved.

We just write 2012-2022, not individual years.
Comment 4 Per Arne Vollan 2022-02-04 08:22:16 PST 
Created attachment 450900 [details]
Patch
Comment 5 Per Arne Vollan 2022-02-04 09:58:56 PST 
Created attachment 450912 [details]
Patch
Comment 6 Per Arne Vollan 2022-02-07 08:18:43 PST 
Created attachment 451104 [details]
Patch